From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Jakub Kicinski <kuba@kernel.org>,
davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, corbet@lwn.net, tsbogend@alpha.franken.de,
mpe@ellerman.id.au, paulus@samba.org, sburla@marvell.com,
vburru@marvell.com, aayarekar@marvell.com, arnd@arndb.de,
zhangyue1@kylinos.cn, linux-doc@vger.kernel.org,
linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-parisc@vger.kernel.org
Subject: Re: [PATCH net-next] eth: de4x5: remove support for Generic DECchip & DIGITAL EtherWORKS PCI/EISA
Date: Thu, 26 May 2022 09:43:30 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2205260933520.394690@ramsan.of.borg> (raw)
In-Reply-To: <f84c4cb17eebe385fe22c3fc4563645742269d46.camel@kernel.crashing.org>
Hi Ben,
On Sat, 21 May 2022, Benjamin Herrenschmidt wrote:
> On Wed, 2022-05-18 at 20:13 -0700, Jakub Kicinski wrote:
>> Looks like almost all changes to this driver had been tree-wide
>> refactoring since git era begun. There is one commit from Al
>> 15 years ago which could potentially be fixing a real bug.
>>
>> The driver is using virt_to_bus() and is a real magnet for pointless
>> cleanups. It seems unlikely to have real users. Let's try to shed
>> this maintenance burden.
>>
>> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>
> Removing this driver will kill support for some rather old PowerMac
> models (some PowerBooks I think, paulus would know). No objection on my
> part, though. I doubt people still use these things with new kernels
> but ... who knows ? :-)
Aren't these PCI, and thus working fine with the PCI-only DE2104X
(dc2104x) or TULIP (dc2114x) drivers?
IIRC, I've initially used the de4x5 driver on Alpha (UDB/Multia) or PPC
(CHRP), but switched to the TULIP driver later (that was before the
dc2104x/dc2114x driver split, hence a loooong time ago).
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2022-05-26 7:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 3:13 [PATCH net-next] eth: de4x5: remove support for Generic DECchip & DIGITAL EtherWORKS PCI/EISA Jakub Kicinski
2022-05-20 10:40 ` Michael Ellerman
2022-05-20 12:30 ` Arnd Bergmann
2022-05-21 2:47 ` Benjamin Herrenschmidt
2022-05-26 7:43 ` Geert Uytterhoeven [this message]
2022-05-26 8:17 ` Arnd Bergmann
2022-05-27 0:16 ` Benjamin Herrenschmidt
2022-05-23 10:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2205260933520.394690@ramsan.of.borg \
--to=geert@linux-m68k.org \
--cc=aayarekar@marvell.com \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paulus@samba.org \
--cc=sburla@marvell.com \
--cc=tsbogend@alpha.franken.de \
--cc=vburru@marvell.com \
--cc=zhangyue1@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).