From: Julian Anastasov <ja@ssi.bg>
To: Ihar Hrachyshka <ihrachys@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>,
He Chunhui <hchunhui@mail.ustc.edu.cn>,
netdev@vger.kernel.org
Subject: Re: [PATCH] neighbour: update neigh timestamps iff update is effective
Date: Tue, 16 May 2017 01:27:52 +0300 (EEST) [thread overview]
Message-ID: <alpine.LFD.2.20.1705160114010.8760@ja.home.ssi.bg> (raw)
In-Reply-To: <CAKwN9=C-_F-8GQ7yMO6wVR1Ukw3gCBYOzxxDRRLU9b-u9P1v-Q@mail.gmail.com>
Hello,
On Mon, 15 May 2017, Ihar Hrachyshka wrote:
> On Mon, May 15, 2017 at 1:05 PM, Julian Anastasov <ja@ssi.bg> wrote:
> >
> > It seems arp_accept value currently has influence on
> > the locktime for GARP requests. My understanding is that
> > locktime is used to ignore replies from proxy_arp
> > routers while the requested IP is present on the LAN
> > and replies immediately. IMHO, GARP requests should not
> > depend on locktime, even when arp_accept=0. For example:
>
> Yes, I believe so.
>
> I actually thought about introducing the patch that does just that:
> forcing override on garp, but then I was thinking, maybe there is some
> reason to still apply locktime rules to garps; f.e. if you have
> multiple nodes carrying the ip address and located on the same
> segment, maybe you want to pick the first that replies to you (in
> theory, it may be the node that is less loaded, or closer to us; but
> then, it's so fragile even if that was the intent...) Do you want me
> to post the patch, or will you cover it?
Feel free to post a patch for this, I see that you change
in another patch the is_garp value, so it seems the same logic
should be used twice.
Regards
prev parent reply other threads:[~2017-05-15 22:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 0:06 [PATCH] neighbour: update neigh timestamps iff update is effective Ihar Hrachyshka
2017-05-15 17:10 ` David Miller
2017-05-15 21:40 ` Ihar Hrachyshka
2017-05-16 15:47 ` Ihar Hrachyshka
2017-05-16 15:44 ` [PATCH v2] " Ihar Hrachyshka
2017-05-17 15:42 ` David Miller
2017-05-15 20:05 ` [PATCH] " Julian Anastasov
2017-05-15 21:35 ` Ihar Hrachyshka
2017-05-15 22:27 ` Julian Anastasov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1705160114010.8760@ja.home.ssi.bg \
--to=ja@ssi.bg \
--cc=davem@davemloft.net \
--cc=hchunhui@mail.ustc.edu.cn \
--cc=ihrachys@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).