From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2000AC63798 for ; Fri, 20 Nov 2020 03:02:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D6A4422267 for ; Fri, 20 Nov 2020 03:02:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726799AbgKTDCP (ORCPT ); Thu, 19 Nov 2020 22:02:15 -0500 Received: from namei.org ([65.99.196.166]:54340 "EHLO namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725887AbgKTDCP (ORCPT ); Thu, 19 Nov 2020 22:02:15 -0500 Received: from localhost (localhost [127.0.0.1]) by namei.org (8.14.4/8.14.4) with ESMTP id 0AK3299S020199; Fri, 20 Nov 2020 03:02:09 GMT Date: Fri, 20 Nov 2020 14:02:09 +1100 (AEDT) From: James Morris To: Paul Moore cc: linux-security-module@vger.kernel.org, netdev@vger.kernel.org, selinux@vger.kernel.org, Herbert Xu Subject: Re: [PATCH] lsm,selinux: pass flowi_common instead of flowi to the LSM hooks In-Reply-To: <160581265397.2575.2287441525647057669.stgit@sifl> Message-ID: References: <160581265397.2575.2287441525647057669.stgit@sifl> User-Agent: Alpine 2.21 (LRH 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 19 Nov 2020, Paul Moore wrote: > As pointed out by Herbert in a recent related patch, the LSM hooks do > not have the necessary address family information to use the flowi > struct safely. As none of the LSMs currently use any of the protocol > specific flowi information, replace the flowi pointers with pointers > to the address family independent flowi_common struct. > > Reported-by: Herbert Xu > Signed-off-by: Paul Moore Acked-by: James Morris -- James Morris