From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5E98C433E0 for ; Mon, 29 Jun 2020 23:30:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A119220781 for ; Mon, 29 Jun 2020 23:30:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729250AbgF2Xa6 (ORCPT ); Mon, 29 Jun 2020 19:30:58 -0400 Received: from mga05.intel.com ([192.55.52.43]:16658 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726317AbgF2Xaz (ORCPT ); Mon, 29 Jun 2020 19:30:55 -0400 IronPort-SDR: In1kYoj0X1IMIwmjoJHotw82x+j92ORtScUpEZh9LkVZtSA91zSLX7+MvDhTJbpb/Z74Dp2uwh lIXo6HMfjU2g== X-IronPort-AV: E=McAfee;i="6000,8403,9666"; a="230949129" X-IronPort-AV: E=Sophos;i="5.75,296,1589266800"; d="scan'208";a="230949129" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2020 16:30:55 -0700 IronPort-SDR: r/ff1793eafJ9LROp5+kT5PF/pGdsiWunYjKScHkVyQfo5g54Vgr11H7bIlA3Tf0nLIhfDss5r zSYHA/erhmaQ== X-IronPort-AV: E=Sophos;i="5.75,296,1589266800"; d="scan'208";a="454377136" Received: from jlbliss-mobl.amr.corp.intel.com ([10.255.231.136]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2020 16:30:54 -0700 Date: Mon, 29 Jun 2020 16:30:54 -0700 (PDT) From: Mat Martineau X-X-Sender: mjmartin@jlbliss-mobl.amr.corp.intel.com To: Davide Caratti cc: Matthieu Baerts , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, mptcp@lists.01.org Subject: Re: [PATCH net-next 5/6] mptcp: __mptcp_tcp_fallback() returns a struct sock In-Reply-To: Message-ID: References: User-Agent: Alpine 2.23 (OSX 453 2020-06-18) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 29 Jun 2020, Davide Caratti wrote: > From: Paolo Abeni > > Currently __mptcp_tcp_fallback() always return NULL > on incoming connections, because MPTCP does not create > the additional socket for the first subflow. > Since the previous commit no __mptcp_tcp_fallback() > caller needs a struct socket, so let __mptcp_tcp_fallback() > return the first subflow sock and cope correctly even with > incoming connections. > > Signed-off-by: Paolo Abeni > Signed-off-by: Davide Caratti > --- > net/mptcp/protocol.c | 22 ++++++++++------------ > 1 file changed, 10 insertions(+), 12 deletions(-) > Reviewed-by: Mat Martineau -- Mat Martineau Intel