From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8BE7C433E0 for ; Mon, 29 Jun 2020 23:31:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA8EE2078B for ; Mon, 29 Jun 2020 23:31:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729507AbgF2XbW (ORCPT ); Mon, 29 Jun 2020 19:31:22 -0400 Received: from mga12.intel.com ([192.55.52.136]:31694 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726794AbgF2XbV (ORCPT ); Mon, 29 Jun 2020 19:31:21 -0400 IronPort-SDR: 0v3dSYDMJvTn0B8AN9CvhNNr2fDqrQxDvY/rZkm22qBOewGNESMbuzTLEVezZdXTcKh9o37yx+ IuwdhftDPzSw== X-IronPort-AV: E=McAfee;i="6000,8403,9666"; a="125730029" X-IronPort-AV: E=Sophos;i="5.75,296,1589266800"; d="scan'208";a="125730029" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2020 16:31:21 -0700 IronPort-SDR: G9mnpHTxFTEzklsbTYsD9NnkScYZSWiBeLDL754H4eHjJwVWkxuEppbYu+G8mtJKDGE67l1xWA wAeuiUISteFQ== X-IronPort-AV: E=Sophos;i="5.75,296,1589266800"; d="scan'208";a="454377280" Received: from jlbliss-mobl.amr.corp.intel.com ([10.255.231.136]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2020 16:31:21 -0700 Date: Mon, 29 Jun 2020 16:31:21 -0700 (PDT) From: Mat Martineau X-X-Sender: mjmartin@jlbliss-mobl.amr.corp.intel.com To: Davide Caratti cc: Matthieu Baerts , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, mptcp@lists.01.org Subject: Re: [PATCH net-next 6/6] mptcp: close poll() races In-Reply-To: <0c0e9026c97b90d92047b3771dc248e5d873ac6a.1593461586.git.dcaratti@redhat.com> Message-ID: References: <0c0e9026c97b90d92047b3771dc248e5d873ac6a.1593461586.git.dcaratti@redhat.com> User-Agent: Alpine 2.23 (OSX 453 2020-06-18) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 29 Jun 2020, Davide Caratti wrote: > From: Paolo Abeni > > mptcp_poll always return POLLOUT for unblocking > connect(), ensure that the socket is a suitable > state. > The MPTCP_DATA_READY bit is never cleared on accept: > ensure we don't leave mptcp_accept() with an empty > accept queue and such bit set. > > Signed-off-by: Paolo Abeni > Signed-off-by: Davide Caratti > --- > net/mptcp/protocol.c | 25 ++++++++++++++++++++----- > 1 file changed, 20 insertions(+), 5 deletions(-) > Reviewed-by: Mat Martineau -- Mat Martineau Intel