From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C23DC43381 for ; Sat, 16 Feb 2019 16:07:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EE9E3222A3 for ; Sat, 16 Feb 2019 16:07:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QO6Vzwr7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730784AbfBPQHn (ORCPT ); Sat, 16 Feb 2019 11:07:43 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:35151 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730658AbfBPQHn (ORCPT ); Sat, 16 Feb 2019 11:07:43 -0500 Received: by mail-wr1-f66.google.com with SMTP id t18so13463693wrx.2 for ; Sat, 16 Feb 2019 08:07:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=WRTFlSMG/BIAlgR4mZopdhAFM28a6u7Vn4eoyAPRE+o=; b=QO6Vzwr7LCQ68KSuf4Z+d/i0J4myeQ+2jhOk6Cl72AkcNEQ8r4ytO7f1y0nvRyd2bp VfuOMKhygSac04uLMyL9LZwmPzUcxT06tWKEtsyIEssJIl8YiCMshviRg00dam02wYre jiJMfeR0GqB2dPQPKweGEpkvUdfo5Jnp1WYTnIXOhH79el4EzbdqmGdvwwBQA/Rf91aO B3Cl+N2xhbXx1OwQwIJeIMgiJ2NLJivcGQvfFObIf8TSoeeb2eLi5f/QupOGwsAHubYI Vm8L2ts5B4bE1q0g5MnrUwl82ggcSxhVwCuKcYKVVAf1fTGS7ay4en0fgnBeYD/ohS3A KhKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WRTFlSMG/BIAlgR4mZopdhAFM28a6u7Vn4eoyAPRE+o=; b=sMJjJZoRN0bmY21X+VEpSL8+8sBmHgcxCsbM+fCLmzaMnGiWMaZGNzHQhhNqKM9G9p pD5/uJeR7QQrdFTGtO4fBnUb9vdDVl79YbTKKh1pBil3DO3C2r2D202pt+yYqzG7e2Ap XDSt92e2a6v6GzHA2MVv4GN0apTonf0O0qosPtTGpq5Rlw1+5tEqhLmPNQKVoOF1TfGP PdnGRAaw5mgpKoqsc4iqAAXkfF8QydYTJjQG6iaIiV6JURx2OFzW2wh9JrpVsNkIttuh avDhTLg9vtuyO3reDlHty8ciToLWBBLuRCUNoTVdVPzCPAJ1ZFQHJ3z6NlIw7PcZCuzp M4hA== X-Gm-Message-State: AHQUAubRJC8GMr1bg9CT1oRogbzuKqhp6opld5lfkykZUgiqSogSTv5K SFNGKWmS/O3duyk4vf1ZoLXmvW65 X-Google-Smtp-Source: AHgI3IaIF3fa2Vh5snscbDw1I2kWLN3q5j/M3IYgMEzDwwpUJohEW86Ue79RGNcaywnuCPv6RWZNlQ== X-Received: by 2002:adf:f80c:: with SMTP id s12mr10269360wrp.150.1550333261013; Sat, 16 Feb 2019 08:07:41 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:fc50:d076:bfa9:dffa? (p200300EA8BF1E200FC50D076BFA9DFFA.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:fc50:d076:bfa9:dffa]) by smtp.googlemail.com with ESMTPSA id b197sm20126682wmd.23.2019.02.16.08.07.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 16 Feb 2019 08:07:40 -0800 (PST) Subject: Re: [PATCH net-next 1/2] net: phy: add helpers for handling C45 10GBT AN register values To: Andrew Lunn Cc: Florian Fainelli , David Miller , "netdev@vger.kernel.org" References: <60b2e19d-e138-dfa0-fa79-19f3cbece99e@gmail.com> <5c217a09-dac8-d8db-3a38-c9a621ae55a6@gmail.com> <20190216160053.GP5699@lunn.ch> From: Heiner Kallweit Message-ID: Date: Sat, 16 Feb 2019 17:07:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190216160053.GP5699@lunn.ch> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 16.02.2019 17:00, Andrew Lunn wrote: > On Fri, Feb 15, 2019 at 09:57:49PM +0100, Heiner Kallweit wrote: >> Similar to the existing helpers for the Clause 22 registers add helpers >> to deal with converting Clause 45 advertisement registers to / from >> link mode bitmaps. >> >> Note that these helpers are defined in linux/mdio.h, not like the >> Clause 22 helpers in linux/mii.h. Reason is that the Clause 45 register >> constants are defined in uapi/linux/mdio.h. And uapi/linux/mdio.h >> includes linux/mii.h before defining the C45 register constants. > > Hi Heiner > > You add three helpers, but the followup patch only uses one of them. > Maybe you should wait until you have real uses of the other two? > Or just add the one helper. > Ah, right. I created all helpers but at least one user isn't ready yet. I'll resend the series with just the helper being used now. > Andrew > Heiner