From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD2BFC10F14 for ; Thu, 18 Apr 2019 11:25:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7EEC22183F for ; Thu, 18 Apr 2019 11:25:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=cumulusnetworks.com header.i=@cumulusnetworks.com header.b="BmIiOTvZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388812AbfDRLZF (ORCPT ); Thu, 18 Apr 2019 07:25:05 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:55174 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727807AbfDRLZE (ORCPT ); Thu, 18 Apr 2019 07:25:04 -0400 Received: by mail-wm1-f66.google.com with SMTP id c1so2343070wml.4 for ; Thu, 18 Apr 2019 04:25:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=shp44un/hYT8d3HZDjj1OayWsYmOta3iMrbXJidHjCE=; b=BmIiOTvZ7NRzd4JXyxVLozK7QvBRgvWWY1qzNpHyXB8iXWEgIOZae+SQLhUdrhkdYG AlZZ1viyWW9QnAH4rADlQA1m0MtgTZsLg2XL3DCA2d7EKuw5uNS61BJ1suTj8GXTeOiX BUnYQcjAc54UPCJdfBaBJAynynjkBmGWIpM0I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=shp44un/hYT8d3HZDjj1OayWsYmOta3iMrbXJidHjCE=; b=h0FWHjnxwL2CFiPAWeesaPqpgd+c9jpYl0ocNxXJEpL5MCEzFd76BavY1OKVvpmXKC jeQnvetGLqy+5kQnhaKCvi6p66Mlu46jmg8CzrfgrFRkKqStQxSiPQq0HqySdkUddXiu 8m7PUTa9n6HCGZFayn3Q+3KHIZ/kmSZAEah1UtDk2PWjzn7iW3x3IKOjmuXBn8OChAY9 8zt9/ee2AC8R2zWNxj/3lQ5CHA9Sz5dunUfJgPaGDpQtkDokl7d65Kw38Nvix44Xz7P+ chpAe0aTdk31UC5L49TGjvmKUpH6eUoLF5wYvfd1fo5xih5kj8nKEReCqQ25eQQStHn1 vsXA== X-Gm-Message-State: APjAAAVitWWID+8DMLWs/ULY0lX7vG3Kx9UwqmlogVc0iiRkapHW9RWH FPTbTD/UjtmC+mUjvrTo/29l0zuETDA= X-Google-Smtp-Source: APXvYqybpcaOIOjn9x66SEbMJyAIYotmjM9L12FDY6eRCOExipsVgiKPurNAwKfD0lo/2Ujk/BUSbA== X-Received: by 2002:a1c:6455:: with SMTP id y82mr2768292wmb.104.1555586702656; Thu, 18 Apr 2019 04:25:02 -0700 (PDT) Received: from [192.168.51.243] ([93.152.141.58]) by smtp.gmail.com with ESMTPSA id w16sm1777780wrt.84.2019.04.18.04.25.01 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 18 Apr 2019 04:25:01 -0700 (PDT) Subject: Re: [PATCH net-next v2 1/5] vlan: support binding link state to vlan member bridge ports To: Mike Manning , netdev@vger.kernel.org, roopa@cumulusnetworks.com References: <20190417181629.5791-1-mmanning@vyatta.att-mail.com> <20190417181629.5791-2-mmanning@vyatta.att-mail.com> From: Nikolay Aleksandrov Message-ID: Date: Thu, 18 Apr 2019 14:25:00 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190417181629.5791-2-mmanning@vyatta.att-mail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 17/04/2019 21:16, Mike Manning wrote: > In the case of vlan filtering on bridges, the bridge may also have the > corresponding vlan devices as upper devices. Currently the link state > of vlan devices is transferred from the lower device. So this is up if > the bridge is in admin up state and there is at least one bridge port > that is up, regardless of the vlan that the port is a member of. > > The link state of the vlan device may need to track only the state of > the subset of ports that are also members of the corresponding vlan, > rather than that of all ports. > > Add a flag to specify a vlan bridge binding mode, by which the link > state is no longer automatically transferred from the lower device, > but is instead determined by the bridge ports that are members of the > vlan. > > Signed-off-by: Mike Manning > --- > include/uapi/linux/if_vlan.h | 9 +++++---- > net/8021q/vlan_dev.c | 3 ++- > net/8021q/vlan_netlink.c | 3 ++- > 3 files changed, 9 insertions(+), 6 deletions(-) > > diff --git a/include/uapi/linux/if_vlan.h b/include/uapi/linux/if_vlan.h > index 7a0e8bd65b6b..90a2c89afc8f 100644 > --- a/include/uapi/linux/if_vlan.h > +++ b/include/uapi/linux/if_vlan.h > @@ -32,10 +32,11 @@ enum vlan_ioctl_cmds { > }; > > enum vlan_flags { > - VLAN_FLAG_REORDER_HDR = 0x1, > - VLAN_FLAG_GVRP = 0x2, > - VLAN_FLAG_LOOSE_BINDING = 0x4, > - VLAN_FLAG_MVRP = 0x8, > + VLAN_FLAG_REORDER_HDR = 0x1, > + VLAN_FLAG_GVRP = 0x2, > + VLAN_FLAG_LOOSE_BINDING = 0x4, > + VLAN_FLAG_MVRP = 0x8, > + VLAN_FLAG_BRIDGE_BINDING = 0x10, > }; > > enum vlan_name_types { > diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c > index 8d77b6ee4477..ed996b500b10 100644 > --- a/net/8021q/vlan_dev.c > +++ b/net/8021q/vlan_dev.c > @@ -223,7 +223,8 @@ int vlan_dev_change_flags(const struct net_device *dev, u32 flags, u32 mask) > u32 old_flags = vlan->flags; > > if (mask & ~(VLAN_FLAG_REORDER_HDR | VLAN_FLAG_GVRP | > - VLAN_FLAG_LOOSE_BINDING | VLAN_FLAG_MVRP)) > + VLAN_FLAG_LOOSE_BINDING | VLAN_FLAG_MVRP | > + VLAN_FLAG_BRIDGE_BINDING)) > return -EINVAL; > > vlan->flags = (old_flags & ~mask) | (flags & mask); > diff --git a/net/8021q/vlan_netlink.c b/net/8021q/vlan_netlink.c > index 9b60c1e399e2..a624dccf68fd 100644 > --- a/net/8021q/vlan_netlink.c > +++ b/net/8021q/vlan_netlink.c > @@ -84,7 +84,8 @@ static int vlan_validate(struct nlattr *tb[], struct nlattr *data[], > flags = nla_data(data[IFLA_VLAN_FLAGS]); > if ((flags->flags & flags->mask) & > ~(VLAN_FLAG_REORDER_HDR | VLAN_FLAG_GVRP | > - VLAN_FLAG_LOOSE_BINDING | VLAN_FLAG_MVRP)) { > + VLAN_FLAG_LOOSE_BINDING | VLAN_FLAG_MVRP | > + VLAN_FLAG_BRIDGE_BINDING)) { > NL_SET_ERR_MSG_MOD(extack, "Invalid VLAN flags"); > return -EINVAL; > } > Acked-by: Nikolay Aleksandrov