From: Joe Perches <joe@perches.com>
To: jeffrey.t.kirsher@intel.com, Forrest Fleming <ffleming@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: "David S. Miller" <davem@davemloft.net>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: intel: Cleanup e1000 - add space between }}
Date: Tue, 27 Aug 2019 12:07:56 -0700 [thread overview]
Message-ID: <b1ea77866e8736fa691cf4658a87ca2c1bf642d6.camel@perches.com> (raw)
In-Reply-To: <c40b4043424055fc4dae97771bb46c8ab15c6230.camel@intel.com>
On Tue, 2019-08-27 at 12:02 -0700, Jeff Kirsher wrote:
> On Mon, 2019-08-26 at 20:41 -0700, Joe Perches wrote:
> > On Mon, 2019-08-26 at 01:03 -0700, Jeff Kirsher wrote:
> > > On Fri, 2019-08-23 at 19:14 +0000, Forrest Fleming wrote:
> > > > suggested by checkpatch
> > > >
> > > > Signed-off-by: Forrest Fleming <ffleming@gmail.com>
> > > > ---
> > > > .../net/ethernet/intel/e1000/e1000_param.c | 28 +++++++++--
> > > > --------
> > > > 1 file changed, 14 insertions(+), 14 deletions(-)
> > >
> > > While I do not see an issue with this change, I wonder how
> > > important it is
> > > to make such a change. Especially since most of the hardware
> > > supported by
> > > this driver is not available for testing. In addition, this is one
> > > suggested change by checkpatch.pl that I personally do not agree
> > > with.
> >
> > I think checkpatch should allow consecutive }}.
>
> Agreed, have you already submitted a formal patch Joe with the
> suggested change below?
No.
> If so, I will ACK it.
Of course you can add an Acked-by:
> > Maybe:
> > ---
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index 287fe73688f0..ac5e0f06e1af 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -4687,7 +4687,7 @@ sub process {
> >
> > # closing brace should have a space following it when it has
> > anything
> > # on the line
> > - if ($line =~ /}(?!(?:,|;|\)))\S/) {
> > + if ($line =~ /}(?!(?:,|;|\)|\}))\S/) {
> > if (ERROR("SPACING",
> > "space required after that close
> > brace '}'\n" . $herecurr) &&
> > $fix) {
> >
> >
next prev parent reply other threads:[~2019-08-27 19:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 19:14 [PATCH] net: intel: Cleanup e1000 - add space between }} Forrest Fleming
2019-08-26 8:03 ` Jeff Kirsher
2019-08-27 3:41 ` Joe Perches
2019-08-27 19:02 ` Jeff Kirsher
2019-08-27 19:07 ` Joe Perches [this message]
2019-08-27 19:45 ` Forrest Fleming
2019-08-27 20:27 ` Jeff Kirsher
2019-08-27 20:27 ` Jeff Kirsher
2019-08-27 20:49 ` [PATCH] checkpatch: Allow consecutive close braces Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1ea77866e8736fa691cf4658a87ca2c1bf642d6.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=ffleming@gmail.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).