From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63658CA9EB0 for ; Sun, 3 Nov 2019 09:50:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C8A92084D for ; Sun, 3 Nov 2019 09:50:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=gmx.net header.i=@gmx.net header.b="Q2LlccFT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727517AbfKCJsp (ORCPT ); Sun, 3 Nov 2019 04:48:45 -0500 Received: from mout.gmx.net ([212.227.17.20]:49945 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726546AbfKCJsp (ORCPT ); Sun, 3 Nov 2019 04:48:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1572774500; bh=N2kuRaL/NF7eaENHQ2C+jDHjdPCKjWSQuPIkJH8g0pI=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=Q2LlccFTCc8rL0GBfgZNe9A0tsXwG98A45djoICyEGqjYkhqOm/3zKgqakud0cGA4 v/FKU9L7M9GbZlJWKd1dFqjGyYoC5x07EqtkZ1SPfPQ4uNIWY+nGCkieEeOjMAraW5 xnqUoW+Ygn0g2uXdDb9SKCo4b9S2b+ThdE/5yZsc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.162] ([37.4.249.112]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MEm27-1iBW6S3N87-00GEz5; Sun, 03 Nov 2019 10:48:19 +0100 Subject: Re: [PATCH RFC V2 3/6] net: bcmgenet: use optional max DMA burst size property To: Florian Fainelli , Matthias Brugger , Matthias Brugger , "David S . Miller" Cc: Doug Berger , netdev@vger.kernel.org, Eric Anholt , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , linux-arm-kernel@lists.infradead.org References: <1572702093-18261-1-git-send-email-wahrenst@gmx.net> <1572702093-18261-4-git-send-email-wahrenst@gmx.net> From: Stefan Wahren Message-ID: Date: Sun, 3 Nov 2019 10:48:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Provags-ID: V03:K1:TjbITlT8S+N4og2qQ/L3geR8VbQ2YegWvTpFryWOffB3y8H+u80 XLSmbluUbx8OVBwiaWmxpvvlM7wsb2uLvD555bD2uNrumhZi/Km8E01QePV4vlhawwvvi4d blhtsDCxHJZhwbGSp6MorGuS40UOzwJwf+U+UlllsOS2EutMSb+q9/izOCTvAo2SuH5T97B gqlKvZmOU9Lbwkqc9OMLg== X-UI-Out-Filterresults: notjunk:1;V03:K0:vWSAY7d1Vro=:zlEbxOb1E1Pibo+wZSmzpV s2Q8zNIc0w6kFiQmPNbea5t7ZzjjZ5gu6CnKjJzT6usef1WJYworSJ54eRD0xcNDcZx9uaAkE Z0SqiKIgnk0F/wSyxgbVOpgZdz/mRtnKYNqirMbnif2ut1B2jtJcfSmgRWBWBMjZrEJofGz68 Ps2S94xnpAsuqY+3LwWGesl8XXUJ6umFuLdeDlZZtwH6N65hYmXUV2J1yaJVyP6XghqU7WhiD xPfyyKFGqD7NE85rpgjaND1xR74W+OmU5bCTD3aRTW3TpzjIgpUYpnn/M+87FNbki2Ayv2T5k nazuloDFRCjO1CYFSLf15r5qDUAdeMP4iIuXvO60qzIOvybpwwboU4VJL6diJpYmSyPYNvLcJ 8zTDJaT7F6Q7vaOsEVZR9fonQJQmPvXIw5+xw13HB7e009mmC1eJCn8VZDtIsqpRH0pqrkF+T 4X6exuiEQNTN64cYUUo+sXvntnPAp1lShFvrqde+bSvW9zQroUqrD3lbvRvP/NX+kXu06pMXH zplhx3X/fTgJN+CfN7m4bvZW5KspwsbM1IqVhQORe8BtXTFcK+vfx4Ae6JA5l80uBTYz6QnOJ eE9GbinWwy8JJobsr2k4Aq6w9FX0HwGhNVlghT/JmlwwMiq3dVs7tKpECrv4u40L1k0cVmsFM 9f/frQFeNkh6C47vhVwZr2grGejjuiPIRC3u4E3HExvuq4NRFoS/kZKHsJtGAYsEH3G7Z9M04 m+B24TQomgVTyV1iPgYk12mxuVRDegQUu945XUyZLP8RxeZfQRs8yV3NmwqWa3eRQJl5T1RBo IsAB1v5CRrgiGrdafnwDyXDWnn4Nw/hwBA3VZ82lAbn9K4j3AQnjl0pkcEPbUPHfzIB9Ajxty o6aGm/1IUHMxB75JO8LE0OXeppBB66DBh+K1zLpGFPnf7oXohZTT+StzCR5B1WjfH86CvV4yg /rxNSKLY5pXbpkRYXGSjWssAn0UmdgyJicTd0qg/qqS7rc/y20q5qIm2j0LbYarOG2UlOFgUO uIud4bHb8XHvUhGt0s5TGc2PzWiE7XL04vIb6WSCY9yzi/XwhDqtI+SiHEOUSaB4oelDJWW5l NqE/ErlKex4zJ8Z8rlc6VMd4mgUROL4QR3q9rERE14XUOFrc/Nchwg/yu1njAUqLkiyzwFD4o a/r1qgdaMbv06t8E38azNMNwAUva4Jx1hk1Jkvzoxn0b4EnYXaZyBSn2QZjM6TEwClZM/filY JycQpcPl3ahxhb5JeHh1hqVHro0yASWcRqkWCkp7tba170VUyu4sKMKo1Tys= Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Florian, Am 02.11.19 um 20:34 schrieb Florian Fainelli: > On 11/2/2019 6:41 AM, Stefan Wahren wrote: >> From: Matthias Brugger >> >> Depending on the HW, the maximal usable DMA burst size can vary. >> If not set accordingly a timeout in the transmit queue happens and no >> package can be sent. Read to optional max-burst-sz property, if not >> present, fallback to the standard value. >> >> Signed-off-by: Matthias Brugger > Missing your Signed-off-by here since you are carrying this patch from > Matthias. oops > >> --- > [snip] > >> + if (dn) { >> + of_property_read_u32(dn, "dma-burst-sz", >> + &priv->dma_max_burst_length); >> + } else { >> + priv->dma_max_burst_length = DMA_MAX_BURST_LENGTH; >> + } > I would maintain the previous position provided on Matthias' patch > series, which is the integration of the GENETv5 hardware block in 2711 > is done in a way that is different enough (due to the SCB/AXI bridge) > that a separate compatibility string would be in order. Once you that > defined that "brcm,bcm2711-genet-v5" compatibility string defined, you > can derive the DMA burst size off of it. this is what i meant with didn't address all your comments. I'm fine with your suggestion, but too lazy to integrate it in this patch series. I assumed Matthias already take care of it. > If adding a compatibility string is not practical because of the > downstream DTBs, then can we at least fix this patch in two ways: > > - define the property in the binding document > - spell out the property in full names: max-dma-burst-size so as to > reflect what it does In case of incompatibilities with the downstream DTB, i will take care of it in the downstream tree like last time. Regards Stefan > > Thanks!