From: Moshe Shemesh <moshe@mellanox.com>
To: Jiri Pirko <jiri@resnulli.us>, Saeed Mahameed <saeedm@mellanox.com>
Cc: "David S. Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Jiri Pirko <jiri@mellanox.com>,
Feras Daoud <ferasda@mellanox.com>,
Alex Vesker <valex@mellanox.com>,
Daniel Jurgens <danielj@mellanox.com>
Subject: Re: [net-next 07/15] net/mlx5: Issue SW reset on FW assert
Date: Mon, 6 May 2019 10:44:08 +0000 [thread overview]
Message-ID: <b246beff-17ce-f21a-b874-55d6b04dbf07@mellanox.com> (raw)
In-Reply-To: <20190505153811.GB31501@nanopsycho.orion>
On 5/5/2019 6:38 PM, Jiri Pirko wrote:
> Sun, May 05, 2019 at 02:33:18AM CEST, saeedm@mellanox.com wrote:
>> From: Feras Daoud <ferasda@mellanox.com>
>>
>> If a FW assert is considered fatal, indicated by a new bit in the health
>> buffer, reset the FW. After the reset go through the normal recovery
>> flow. Only one PF needs to issue the reset, so an attempt is made to
>> prevent the 2nd function from also issuing the reset.
>> It's not an error if that happens, it just slows recovery.
>>
>> Signed-off-by: Feras Daoud <ferasda@mellanox.com>
>> Signed-off-by: Alex Vesker <valex@mellanox.com>
>> Signed-off-by: Moshe Shemesh <moshe@mellanox.com>
>> Signed-off-by: Daniel Jurgens <danielj@mellanox.com>
>> Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
>> ---
>> .../ethernet/mellanox/mlx5/core/diag/crdump.c | 13 +-
>> .../net/ethernet/mellanox/mlx5/core/health.c | 157 +++++++++++++++++-
>> .../net/ethernet/mellanox/mlx5/core/main.c | 1 +
>> .../ethernet/mellanox/mlx5/core/mlx5_core.h | 2 +
>> include/linux/mlx5/device.h | 10 +-
>> include/linux/mlx5/driver.h | 1 +
>> 6 files changed, 176 insertions(+), 8 deletions(-)
>>
>
> [...]
>
>
>> +void mlx5_error_sw_reset(struct mlx5_core_dev *dev)
>> +{
>> + unsigned long end, delay_ms = MLX5_FW_RESET_WAIT_MS;
>> + int lock = -EBUSY;
>> +
>> + mutex_lock(&dev->intf_state_mutex);
>> + if (dev->state != MLX5_DEVICE_STATE_INTERNAL_ERROR)
>> + goto unlock;
>> +
>> + mlx5_core_err(dev, "start\n");
>
> Leftover?
>
Not leftover, it was just moved from one point to another.
next prev parent reply other threads:[~2019-05-06 10:44 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-05 0:32 [pull request][net-next 00/15] Mellanox, mlx5 Firmware devlink health and sw reset Saeed Mahameed
2019-05-05 0:32 ` [net-next 01/15] net/mlx5: Move all devlink related functions calls to devlink.c Saeed Mahameed
2019-05-05 0:32 ` [net-next 02/15] net/mlx5: Add Vendor Specific Capability access gateway Saeed Mahameed
2019-05-05 0:33 ` [net-next 03/15] net/mlx5: Add Crdump FW snapshot support Saeed Mahameed
2019-05-05 15:36 ` Jiri Pirko
2019-05-05 0:33 ` [net-next 04/15] net/mlx5: Add support for devlink region_snapshot parameter Saeed Mahameed
2019-05-05 0:33 ` [net-next 05/15] net/mlx5: Handle SW reset of FW in error flow Saeed Mahameed
2019-05-05 0:33 ` [net-next 06/15] net/mlx5: Control CR-space access by different PFs Saeed Mahameed
2019-05-05 0:33 ` [net-next 07/15] net/mlx5: Issue SW reset on FW assert Saeed Mahameed
2019-05-05 15:38 ` Jiri Pirko
2019-05-06 10:44 ` Moshe Shemesh [this message]
2019-05-05 0:33 ` [net-next 08/15] net/mlx5: Refactor print health info Saeed Mahameed
2019-05-05 15:42 ` Jiri Pirko
2019-05-05 0:33 ` [net-next 09/15] net/mlx5: Create FW devlink health reporter Saeed Mahameed
2019-05-05 15:42 ` Jiri Pirko
2019-05-06 10:45 ` Moshe Shemesh
2019-05-06 11:38 ` Jiri Pirko
2019-05-06 19:52 ` Saeed Mahameed
2019-05-06 21:46 ` Alexei Starovoitov
2019-05-07 5:59 ` Jiri Pirko
2019-05-07 6:01 ` Jiri Pirko
2019-05-07 0:11 ` Jakub Kicinski
2019-05-05 0:33 ` [net-next 10/15] net/mlx5: Add core dump register access functions Saeed Mahameed
2019-05-05 0:33 ` [net-next 11/15] net/mlx5: Add support for FW reporter dump Saeed Mahameed
2019-05-05 15:49 ` Jiri Pirko
2019-05-06 10:51 ` Moshe Shemesh
2019-05-06 11:37 ` Jiri Pirko
2019-05-05 0:33 ` [net-next 12/15] net/mlx5: Report devlink health on FW issues Saeed Mahameed
2019-05-05 0:33 ` [net-next 13/15] net/mlx5: Add fw fatal devlink health reporter Saeed Mahameed
2019-05-05 0:33 ` [net-next 14/15] net/mlx5: Add support for FW fatal reporter dump Saeed Mahameed
2019-05-05 15:52 ` Jiri Pirko
2019-05-06 10:54 ` Moshe Shemesh
2019-05-06 11:42 ` Jiri Pirko
2019-05-05 0:33 ` [net-next 15/15] net/mlx5: Report devlink health on FW fatal issues Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b246beff-17ce-f21a-b874-55d6b04dbf07@mellanox.com \
--to=moshe@mellanox.com \
--cc=danielj@mellanox.com \
--cc=davem@davemloft.net \
--cc=ferasda@mellanox.com \
--cc=jiri@mellanox.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=valex@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).