From: Andrew Lunn <andrew@lunn.ch>
To: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Cc: Fabio Estevam <festevam@denx.de>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Michael Krummsdorf <michael.krummsdorf@tq-group.com>,
netdev@vger.kernel.org, linux@ew.tq-group.com
Subject: Re: Regression: Commit "net: dsa: mv88e6xxx: Avoid EEPROM timeout when EEPROM is absent" *causing* timeouts after kernel update
Date: Wed, 17 Apr 2024 15:56:31 +0200 [thread overview]
Message-ID: <b3f72f80-e41d-4abd-bb6f-10f3b58e65c1@lunn.ch> (raw)
In-Reply-To: <1f22520948180e55125fdc686a0de8a93c317e5f.camel@ew.tq-group.com>
> Any suggestions what the best way to handle this is?
>
> The 88E6520/6020 "Functional Spec" seems to suggest that the old behaviour (waiting for the EEInt
> flag) is more appropriate on these models, but I guess we should only do that *after* the hardware
> reset, as something else may already have read and cleared the EEInt flag before the kernel probes
> the switch otherwise... Maybe something can be done with an explicit EEPROM reload (Global1 Control
> register flag RL)?
By the time mv88e6xxx_g2_eeprom_wait() is called, we have detected the
chip, and know what it is. We have the chip->info->ops structure. So
maybe add an op to be used in mv88e6xxx_hardware_reset() to wait for
the EEPROM to be idle? You can then have the family 6250 use a
different mechanism to all the other devices.
Andrew
prev parent reply other threads:[~2024-04-17 13:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 14:38 Regression: Commit "net: dsa: mv88e6xxx: Avoid EEPROM timeout when EEPROM is absent" *causing* timeouts after kernel update Matthias Schiffer
2024-04-17 13:56 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3f72f80-e41d-4abd-bb6f-10f3b58e65c1@lunn.ch \
--to=andrew@lunn.ch \
--cc=festevam@denx.de \
--cc=florian.fainelli@broadcom.com \
--cc=linux@ew.tq-group.com \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=michael.krummsdorf@tq-group.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).