From: tanhuazhong <tanhuazhong@huawei.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Network Development <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
<salil.mehta@huawei.com>, <yisen.zhuang@huawei.com>,
<linuxarm@huawei.com>, Jakub Kicinski <kuba@kernel.org>
Subject: Re: [RFC net-next] udp: add a GSO type for UDPv6
Date: Thu, 3 Sep 2020 09:25:39 +0800 [thread overview]
Message-ID: <b4bf766c-4d56-cf6b-9018-468ebcd3e147@huawei.com> (raw)
In-Reply-To: <CA+FuTSc_KOZRTdh34Vw3gTCzGMmi5XvDZKjpWMOXw7aby53wqw@mail.gmail.com>
On 2020/9/2 22:33, Willem de Bruijn wrote:
> On Wed, Sep 2, 2020 at 2:18 PM Huazhong Tan <tanhuazhong@huawei.com> wrote:
>>
>> In some cases, for UDP GSO, UDPv4 and UDPv6 need to be handled
>> separately, for example, checksum offload, so add new GSO type
>> SKB_GSO_UDPV6_L4 for UDPv6, and the old SKB_GSO_UDP_L4 stands
>> for UDPv4.
>
> This is in preparation for hardware you have that actually cares about
> this distinction, I guess?
>
it is mainly for separating checksum offload of IPv4 and IPv6 right now.
with this patch, the user can switch checksum offload of IPv4 and not
affect IPv6's, vice versa.
>
>> diff --git a/include/linux/netdev_features.h b/include/linux/netdev_features.h
>> index 2cc3cf8..b7c1a76 100644
>> --- a/include/linux/netdev_features.h
>> +++ b/include/linux/netdev_features.h
>> @@ -54,6 +54,7 @@ enum {
>> NETIF_F_GSO_UDP_BIT, /* ... UFO, deprecated except tuntap */
>> NETIF_F_GSO_UDP_L4_BIT, /* ... UDP payload GSO (not UFO) */
>> NETIF_F_GSO_FRAGLIST_BIT, /* ... Fraglist GSO */
>> + NETIF_F_GSO_UDPV6_L4_BIT, /* ... UDPv6 payload GSO (not UFO) */
>> /**/NETIF_F_GSO_LAST = /* last bit, see GSO_MASK */
>> NETIF_F_GSO_FRAGLIST_BIT,
>
> Need to update NETIF_F_GSO_LAST then, too.
ok, thanks.
>
>
next prev parent reply other threads:[~2020-09-03 1:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 12:15 Huazhong Tan
2020-09-02 14:33 ` Willem de Bruijn
2020-09-03 1:25 ` tanhuazhong [this message]
2020-09-02 22:43 ` David Miller
2020-09-03 1:26 ` tanhuazhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4bf766c-4d56-cf6b-9018-468ebcd3e147@huawei.com \
--to=tanhuazhong@huawei.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=willemdebruijn.kernel@gmail.com \
--cc=yisen.zhuang@huawei.com \
--subject='Re: [RFC net-next] udp: add a GSO type for UDPv6' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).