From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71C68C433E2 for ; Thu, 3 Sep 2020 01:25:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B5AF20786 for ; Thu, 3 Sep 2020 01:25:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727963AbgICBZt (ORCPT ); Wed, 2 Sep 2020 21:25:49 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:51204 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727037AbgICBZs (ORCPT ); Wed, 2 Sep 2020 21:25:48 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 9F863FB4BAF801B71375; Thu, 3 Sep 2020 09:25:46 +0800 (CST) Received: from [127.0.0.1] (10.74.149.191) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.487.0; Thu, 3 Sep 2020 09:25:40 +0800 Subject: Re: [RFC net-next] udp: add a GSO type for UDPv6 To: Willem de Bruijn CC: David Miller , Network Development , linux-kernel , , , , Jakub Kicinski References: <1599048911-7923-1-git-send-email-tanhuazhong@huawei.com> From: tanhuazhong Message-ID: Date: Thu, 3 Sep 2020 09:25:39 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.74.149.191] X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2020/9/2 22:33, Willem de Bruijn wrote: > On Wed, Sep 2, 2020 at 2:18 PM Huazhong Tan wrote: >> >> In some cases, for UDP GSO, UDPv4 and UDPv6 need to be handled >> separately, for example, checksum offload, so add new GSO type >> SKB_GSO_UDPV6_L4 for UDPv6, and the old SKB_GSO_UDP_L4 stands >> for UDPv4. > > This is in preparation for hardware you have that actually cares about > this distinction, I guess? > it is mainly for separating checksum offload of IPv4 and IPv6 right now. with this patch, the user can switch checksum offload of IPv4 and not affect IPv6's, vice versa. > >> diff --git a/include/linux/netdev_features.h b/include/linux/netdev_features.h >> index 2cc3cf8..b7c1a76 100644 >> --- a/include/linux/netdev_features.h >> +++ b/include/linux/netdev_features.h >> @@ -54,6 +54,7 @@ enum { >> NETIF_F_GSO_UDP_BIT, /* ... UFO, deprecated except tuntap */ >> NETIF_F_GSO_UDP_L4_BIT, /* ... UDP payload GSO (not UFO) */ >> NETIF_F_GSO_FRAGLIST_BIT, /* ... Fraglist GSO */ >> + NETIF_F_GSO_UDPV6_L4_BIT, /* ... UDPv6 payload GSO (not UFO) */ >> /**/NETIF_F_GSO_LAST = /* last bit, see GSO_MASK */ >> NETIF_F_GSO_FRAGLIST_BIT, > > Need to update NETIF_F_GSO_LAST then, too. ok, thanks. > >