From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: David Heidelberg <david@ixit.cz>,
Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, ~okias/devicetree@lists.sr.ht
Subject: Re: [PATCH] dt-bindings: net: nfc: nxp,pn544: Convert txt bindings to yaml
Date: Sat, 9 Oct 2021 16:38:17 +0200 [thread overview]
Message-ID: <b52a93da-e805-b04e-3b50-454956764d04@canonical.com> (raw)
In-Reply-To: <20211009111215.51775-1-david@ixit.cz>
On 09/10/2021 13:12, David Heidelberg wrote:
> Convert bindings for NXP PN544 NFC driver to YAML syntax.
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> .../bindings/net/nfc/nxp,pn544.yaml | 67 +++++++++++++++++++
> .../devicetree/bindings/net/nfc/pn544.txt | 33 ---------
> 2 files changed, 67 insertions(+), 33 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/net/nfc/nxp,pn544.yaml
> delete mode 100644 Documentation/devicetree/bindings/net/nfc/pn544.txt
>
Hi,
Thanks for the patch. Please use get_maintainers.pl to get the list of
folks to Cc. You missed Rob. This is even weirder because you put him as
a maintainer...
> diff --git a/Documentation/devicetree/bindings/net/nfc/nxp,pn544.yaml b/Documentation/devicetree/bindings/net/nfc/nxp,pn544.yaml
> new file mode 100644
> index 000000000000..c44f5ee8e2c2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/nfc/nxp,pn544.yaml
> @@ -0,0 +1,67 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/nfc/nxp,pn544.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP Semiconductors PN544 NFC Controller
> +
> +maintainers:
> + - Rob Herring <robh+dt@kernel.org>
This should not be Rob but someone responsible for the driver. I see
there is no maintainers entry, so put there me:
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> +
> +properties:
> + compatible:
> + const: nxp,pn544-i2c
> +
> + clock-frequency: true
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + enable-gpios:
> + description: Output GPIO pin used for enabling/disabling the PN544
> +
> + firmware-gpios:
> + description: Output GPIO pin used to enter firmware download mode
> +
> + pinctrl-names:
> + items:
> + - const: default
> +
> + pintctrl-0: true
Drop pinctrl, there is a typo here and this is already provided by the
schema.
> +
> +required:
> + - compatible
> + - clock-frequency
> + - reg
> + - interrupts
> + - enable-gpios
> + - firmware-gpios
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
Use 4-space indentation for the example. Easier to read.
> +
> + pn544@28 {
Nodes should have generic name, so "nfc".
> + compatible = "nxp,pn544-i2c";
Best regards,
Krzysztof
prev parent reply other threads:[~2021-10-09 14:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-09 11:12 [PATCH] dt-bindings: net: nfc: nxp,pn544: Convert txt bindings to yaml David Heidelberg
2021-10-09 14:38 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b52a93da-e805-b04e-3b50-454956764d04@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=davem@davemloft.net \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=~okias/devicetree@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).