netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick Menschel <menschel.p@posteo.de>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Drew Fustini <drew@beagleboard.org>,
	netdev@vger.kernel.org, linux-can@vger.kernel.org,
	Will C <will@macchina.cc>
Subject: Re: [net-next 6/6] can: mcp251xfd: mcp251xfd_regmap_crc_read(): work around broken CRC on TBC register
Date: Sun,  9 May 2021 07:46:20 +0000	[thread overview]
Message-ID: <b58d4484-db27-f199-875e-ae3694cd271f@posteo.de> (raw)
In-Reply-To: <7cb69acc-ee56-900b-0320-a893f687d850@posteo.de>

Am 08.05.21 um 20:36 schrieb Patrick Menschel:
> Am 07.05.21 um 10:25 schrieb Marc Kleine-Budde:
>> On 07.05.2021 08:21:57, Patrick Menschel wrote:
>>>>>> Would it be possible for you to pull these patches into a v5.10 branch
>>>>>> in your linux-rpi repo [1]?
>>>>>
>>>>> Here you are:
>>>>>
>>>>> https://github.com/marckleinebudde/linux-rpi/tree/v5.10-rpi/backport-performance-improvements
>>>>>
>>>>> I've included the UINC performance enhancements, too. The branch is compiled
>>>>> tested only, though. I'll send a pull request to the rpi kernel after I've
>>>>> testing feedback from you.
>>>>
>>>> Drew, Patrick, have you tested this branch? If so I'll send a pull
>>>> request to the raspi kernel.
>>>>
>>
>>> not yet. Thanks for reminding me. I'll start a native build on a pi0w asap.
>>>
>>> Is there any test application or stress test that I should run?
>>
>> No, not any particular, do your normal (stress) testing.
>>
> Following up on this.
> 
> ...
> 
> Do I have to change my test?

Hi Marc,

I changed my test to 1 hour and removed the sleep statement.
Still no measurable difference for performance and no CRC Errors with
both kernels.

Apparently the test is hard on the CPU, I have two pytest processes
listed in htop one with 80%CPU and one with 60% CPU, approx 30% ram
usage of 512MB. I have no clue how it reaches the CPU values, there
should be only one CPU on the pi0w.


### 5.10.17+ on pi0w ###

2021-05-09 08:02:56 [    INFO] 725649 frames in 1:00:00
(test_socketcan.py:890)


### 5.10.31-performance-backports+ on pi0w ###

2021-05-09 09:13:32 [    INFO] 715936 frames in 1:00:00
(test_socketcan.py:890)


I'll switch boards to a pi3b and test again with these settings.

Best Regards,
Patrick

  reply	other threads:[~2021-05-09  7:46 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-07  8:01 pull-request: can-next 2021-04-07 Marc Kleine-Budde
2021-04-07  8:01 ` [net-next 1/6] can: skb: alloc_can{,fd}_skb(): set "cf" to NULL if skb allocation fails Marc Kleine-Budde
2021-04-07  8:01 ` [net-next 2/6] can: m_can: m_can_receive_skb(): add missing error handling to can_rx_offload_queue_sorted() call Marc Kleine-Budde
2021-04-07  8:01 ` [net-next 3/6] can: c_can: remove unused enum BOSCH_C_CAN_PLATFORM Marc Kleine-Budde
2021-04-07  8:01 ` [net-next 4/6] can: mcp251xfd: add BQL support Marc Kleine-Budde
2021-04-07  8:01 ` [net-next 5/6] can: mcp251xfd: mcp251xfd_regmap_crc_read_one(): Factor out crc check into separate function Marc Kleine-Budde
2021-04-07  8:01 ` [net-next 6/6] can: mcp251xfd: mcp251xfd_regmap_crc_read(): work around broken CRC on TBC register Marc Kleine-Budde
2021-04-21 19:58   ` Drew Fustini
2021-04-22  7:18     ` Marc Kleine-Budde
2021-04-22 16:46       ` Patrick Menschel
2021-05-07  7:25       ` Marc Kleine-Budde
2021-05-07  8:21         ` Patrick Menschel
2021-05-07  8:25           ` Marc Kleine-Budde
2021-05-08 18:36             ` Patrick Menschel
2021-05-09  7:46               ` Patrick Menschel [this message]
2021-05-10  7:45                 ` Marc Kleine-Budde
2021-05-20 10:29                   ` Patrick Menschel
2021-05-10  7:43               ` Marc Kleine-Budde
2021-12-07 16:53                 ` Modilaynen, Pavel
2021-12-08  8:54                   ` Marc Kleine-Budde
2021-12-09 10:22                   ` Thomas.Kopp
2021-12-09 11:17                     ` AW: " Sven Schuchmann
2021-12-09 11:27                       ` Marc Kleine-Budde
2021-12-09 12:53                         ` AW: " Sven Schuchmann
2021-12-13 22:12                     ` Modilaynen, Pavel
2021-12-21 22:24                       ` Thomas.Kopp
2022-06-21 14:25                         ` Marc Kleine-Budde
2022-06-22  8:19                           ` Marc Kleine-Budde
2022-06-22 13:47                           ` Thomas.Kopp
2022-06-26 19:14                         ` Marc Kleine-Budde
2021-05-07 22:36         ` Drew Fustini
2021-05-08 12:30           ` Marc Kleine-Budde
2021-04-07 22:10 ` pull-request: can-next 2021-04-07 patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b58d4484-db27-f199-875e-ae3694cd271f@posteo.de \
    --to=menschel.p@posteo.de \
    --cc=drew@beagleboard.org \
    --cc=linux-can@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=will@macchina.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).