From: Joe Perches <joe@perches.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Kalle Valo <kvalo@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH v1 1/2] wireless: ray_cs: Utilize strnlen() in parse_addr()
Date: Fri, 03 Jun 2022 09:50:55 -0700 [thread overview]
Message-ID: <b59b922f96603468cbbe69b6359ec417083c526b.camel@perches.com> (raw)
In-Reply-To: <20220603164414.48436-1-andriy.shevchenko@linux.intel.com>
On Fri, 2022-06-03 at 19:44 +0300, Andy Shevchenko wrote:
> Instead of doing simple operations and using an additional variable on stack,
> utilize strnlen() and reuse len variable.
[]
> diff --git a/drivers/net/wireless/ray_cs.c b/drivers/net/wireless/ray_cs.c
[]
> + while (len > 0) {
> + if ((k = hex_to_bin(in_str[len--])) != -1)
> out[i] = k;
> else
> return 0;
could be reversed and unindented
>
> - if (j == 0)
> + if (len == 0)
> break;
> - if ((k = hex_to_bin(in_str[j--])) != -1)
> + if ((k = hex_to_bin(in_str[len--])) != -1)
> out[i] += k << 4;
> else
> return 0;
and here
next prev parent reply other threads:[~2022-06-03 16:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 16:44 [PATCH v1 1/2] wireless: ray_cs: Utilize strnlen() in parse_addr() Andy Shevchenko
2022-06-03 16:44 ` [PATCH v1 2/2] wireless: ray_cs: Drop useless status variable " Andy Shevchenko
2022-06-03 16:50 ` Joe Perches [this message]
2022-06-03 17:05 ` [PATCH v1 1/2] wireless: ray_cs: Utilize strnlen() " Andy Shevchenko
2022-06-08 8:08 ` [v1,1/2] wifi: " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b59b922f96603468cbbe69b6359ec417083c526b.camel@perches.com \
--to=joe@perches.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).