From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B3E8C43381 for ; Sun, 24 Feb 2019 02:59:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DF0662085B for ; Sun, 24 Feb 2019 02:59:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="s9Mh25ue" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728099AbfBXC7D (ORCPT ); Sat, 23 Feb 2019 21:59:03 -0500 Received: from mail-pg1-f196.google.com ([209.85.215.196]:44060 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727475AbfBXC7C (ORCPT ); Sat, 23 Feb 2019 21:59:02 -0500 Received: by mail-pg1-f196.google.com with SMTP id j3so2872955pgm.11 for ; Sat, 23 Feb 2019 18:59:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=KMAUnt5J6uNEgDQyh0d4W19/CVs0fc3mlkz9YWd3EI8=; b=s9Mh25uevrI5BQMoXZ+HkRH+CtedMGdbIebw+zL0lEhkanEMpHAx1WhQNXEVxzkfwo OUgizvleuWH9utfZjBL/FM99ZPY3JSM4DqLGYzQmQz995JJEFJu5p8AKS+PALqwrUP5D LFMYGONQV4oG496GAGq3jVDOlfhKye64J17TcibmKmhCfJ+8D3qIrqPafMY2USQQ7Uqf Z+Ls1zF4TlrCw8QrMZExtv7GTUIf/YBfNETDLsrRB1aEmjtXjBczHykUkvJJLeBZKIr+ PRvfvLkWbcvfNwkKVXmnXkVY9k4bqexmFEs3x90cPqN+0M4z5ABTKXH7Nn0PEE27U+Qt JJhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KMAUnt5J6uNEgDQyh0d4W19/CVs0fc3mlkz9YWd3EI8=; b=pIGBjRnxQyWiLa0xICDogSg5nsyIP4lgDguip5eyhFEc/exx0+zRR4IlpskB+vDlx0 SZcehaWHwQN8j6utExNEPW45ms2qvX4cwWJD0pxJ3dWZt1NzBwRD3wI7yPVqWrOxiB0w uCpCMO/lnL1G7648s0x1er8NxHnRBYHD1xFCv/MDUC1+1wQ7Bfq+mSjAtw37NPrualW8 X5w8JXGI5EKJ/wkFD2T1ffJuA9pvDfscraR2REfXu1f6qgNb4zq2KReJSUzGzYr/DVse ZmyRFVr0ZC6gtEaDwuiFU7s2nI/t8W1XxDCHfF/V+WuVAQmCLofkiNeHhcQtwHk+55KW v0zg== X-Gm-Message-State: AHQUAubOrPBrEKx6npNVOnrxQWtLXqcHMbtOnhNtgvSoVz0qj9D5VRKK uwc0ROzBZQ5kSZxZzOYx6u8= X-Google-Smtp-Source: AHgI3IYXgzxYC8jnU9JqWMBRplZKlx5CHXl/si2FPyeN9WiOAM4xrChmuwDd5oZXc2DN/eVBJm3KMA== X-Received: by 2002:a63:f544:: with SMTP id e4mr6928480pgk.145.1550977142201; Sat, 23 Feb 2019 18:59:02 -0800 (PST) Received: from [172.27.227.179] ([216.129.126.118]) by smtp.googlemail.com with ESMTPSA id f18sm8448308pgf.26.2019.02.23.18.58.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Feb 2019 18:59:00 -0800 (PST) Subject: Re: [PATCH v2 bpf-next 0/9] bpf: Network Resource Manager (NRM) To: Alexei Starovoitov , Eric Dumazet Cc: brakmo , netdev , Martin Lau , Alexei Starovoitov , Daniel Borkmann , Kernel Team References: <20190223010703.678070-1-brakmo@fb.com> <184fd1a4-451e-2585-6aad-d9b0b10fd9aa@gmail.com> <2507e7b5-2ffa-e080-698a-18a7b0ee36ac@gmail.com> <20190223204046.zjvcxh7cgzshqllm@ast-mbp.dhcp.thefacebook.com> <49fbc4c9-6e8d-5115-0860-e418427a2ce5@gmail.com> <20190223232530.qjb5z66x6amoiis4@ast-mbp.dhcp.thefacebook.com> From: David Ahern Message-ID: Date: Sat, 23 Feb 2019 21:58:57 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190223232530.qjb5z66x6amoiis4@ast-mbp.dhcp.thefacebook.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/23/19 6:25 PM, Alexei Starovoitov wrote: >>> hmm. please see our NRM presentation at LPC. Reference? We also gave a talk about a resource manager in November 2017: https://netdevconf.org/2.2/papers/roulin-hardwareresourcesmgmt-talk.pdf in this case the context is hardware resources for networking which aligns with devlink and switchdev. >>> It is a networking _resource_ management for cgroups. >>> Bandwidth enforcement is a particular example. >>> It's not a policer either. >>> >> >> Well, this definitely looks a policer to me, sorry if we disagree, this is fine. > > this particular example certainly does look like it. we both agree. > It's overall direction of this work that is aiming to do > network resource management. For example bpf prog may choose > to react on SLA violations in one cgroup by throttling flows > in the other cgroup. Aggregated per-cgroup bandwidth doesn't > need to cross a threshold for bpf prog to take action. > It could do 'work conserving' 'policer'. > I think this set of patches represent a revolutionary approach and existing > networking nomenclature doesn't have precise words to describe it :) > 'NRM' describes our goals the best. Are you doing something beyond bandwidth usage? e.g., are you limiting neighbor entries, fdb entries or FIB entries by cgroup? what about router interfaces or vlans? I cannot imagine why or how you would manage that but my point is the meaning of 'network resources'. > Other folks may choose to use it differently, of course. > Note that NRM abbreviation doesn't leak anywhere in uapi. > It's only used in examples. So not sure what we're arguing about. > It was a simple request for a more specific name that better represents the scope of the project. Everything presented so far has been about bandwidth.