From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC6CAC63697 for ; Tue, 17 Nov 2020 20:39:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D92C221FC for ; Tue, 17 Nov 2020 20:39:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728780AbgKQUiy (ORCPT ); Tue, 17 Nov 2020 15:38:54 -0500 Received: from smtp03.smtpout.orange.fr ([80.12.242.125]:19436 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726955AbgKQUiy (ORCPT ); Tue, 17 Nov 2020 15:38:54 -0500 Received: from [192.168.1.41] ([92.131.86.32]) by mwinf5d57 with ME id tYel230090hrljw03YelgD; Tue, 17 Nov 2020 21:38:50 +0100 X-ME-Helo: [192.168.1.41] X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Tue, 17 Nov 2020 21:38:50 +0100 X-ME-IP: 92.131.86.32 Subject: Re: [PATCH net] atl1e: fix error return code in atl1e_probe() To: Zhang Changzhong , jcliburn@gmail.com, chris.snook@gmail.com, davem@davemloft.net, kuba@kernel.org, mst@redhat.com, leon@kernel.org, hkallweit1@gmail.com, tglx@linutronix.de, jesse.brandeburg@intel.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1605581875-36281-1-git-send-email-zhangchangzhong@huawei.com> From: Marion & Christophe JAILLET Message-ID: Date: Tue, 17 Nov 2020 21:38:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: <1605581875-36281-1-git-send-email-zhangchangzhong@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Le 17/11/2020 à 03:57, Zhang Changzhong a écrit : > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: 85eb5bc33717 ("net: atheros: switch from 'pci_' to 'dma_' API") Hi, should it have any importance, the Fixes tag is wrong. The issue was already there before 85eb5bc33717 which was just a mechanical update. just my 2c CJ > Reported-by: Hulk Robot > Signed-off-by: Zhang Changzhong > --- > drivers/net/ethernet/atheros/atl1e/atl1e_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/atheros/atl1e/atl1e_main.c b/drivers/net/ethernet/atheros/atl1e/atl1e_main.c > index 098b032..ff9f96d 100644 > --- a/drivers/net/ethernet/atheros/atl1e/atl1e_main.c > +++ b/drivers/net/ethernet/atheros/atl1e/atl1e_main.c > @@ -2312,8 +2312,8 @@ static int atl1e_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > * various kernel subsystems to support the mechanics required by a > * fixed-high-32-bit system. > */ > - if ((dma_set_mask(&pdev->dev, DMA_BIT_MASK(32)) != 0) || > - (dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(32)) != 0)) { > + err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); > + if (err) { > dev_err(&pdev->dev, "No usable DMA configuration,aborting\n"); > goto err_dma; > }