From: Ben Greear <greearb@candelatech.com>
To: Eric Dumazet <eric.dumazet@gmail.com>, netdev <netdev@vger.kernel.org>
Subject: Re: 5.15-rc3+ crash in fq-codel?
Date: Wed, 29 Sep 2021 17:04:09 -0700 [thread overview]
Message-ID: <b7df0abb-8bdd-6348-a60a-75a66d6a9d91@candelatech.com> (raw)
In-Reply-To: <8768df9e-f1f6-db25-15d8-cabed2346f32@candelatech.com>
On 9/29/21 4:48 PM, Ben Greear wrote:
> On 9/29/21 4:42 PM, Eric Dumazet wrote:
>>
>>
>> On 9/29/21 4:28 PM, Eric Dumazet wrote:
>>>
>>
>>>
>>> Actually the bug seems to be in pktgen, vs NET_XMIT_CN
>>>
>>> You probably would hit the same issues with other qdisc also using NET_XMIT_CN
>>>
>>
>> I would try the following patch :
>>
>> diff --git a/net/core/pktgen.c b/net/core/pktgen.c
>> index a3d74e2704c42e3bec1aa502b911c1b952a56cf1..0a2d9534f8d08d1da5dfc68c631f3a07f95c6f77 100644
>> --- a/net/core/pktgen.c
>> +++ b/net/core/pktgen.c
>> @@ -3567,6 +3567,7 @@ static void pktgen_xmit(struct pktgen_dev *pkt_dev)
>> case NET_XMIT_DROP:
>> case NET_XMIT_CN:
>> /* skb has been consumed */
>> + pkt_dev->last_ok = 1;
>> pkt_dev->errors++;
>> break;
>> default: /* Drivers are not supposed to return other values! */
While patching my variant of pktgen, I took a look at the 'default' case. I think
it should probably go above NET_XMIT_DROP and fallthrough into the consumed pkt path?
Although, probably not a big deal since only bugs elsewhere would hit that path, and
we don't really know if skb would be consumed in that case or not.
Thanks,
Ben
next prev parent reply other threads:[~2021-09-30 0:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 23:30 5.15-rc3+ crash in fq-codel? Ben Greear
2021-09-27 23:49 ` Eric Dumazet
2021-09-28 0:04 ` Ben Greear
2021-09-28 0:16 ` Ben Greear
2021-09-28 22:00 ` Ben Greear
2021-09-28 23:25 ` Eric Dumazet
2021-09-29 19:07 ` Ben Greear
2021-09-29 23:21 ` Eric Dumazet
2021-09-29 23:28 ` Eric Dumazet
2021-09-29 23:42 ` Eric Dumazet
2021-09-29 23:48 ` Ben Greear
2021-09-30 0:04 ` Ben Greear [this message]
2021-09-30 0:29 ` Eric Dumazet
2021-09-30 0:40 ` Eric Dumazet
2021-09-30 1:36 ` Ben Greear
2021-09-30 16:44 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7df0abb-8bdd-6348-a60a-75a66d6a9d91@candelatech.com \
--to=greearb@candelatech.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).