From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E44BBC43381 for ; Wed, 27 Feb 2019 14:47:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9E7282083D for ; Wed, 27 Feb 2019 14:47:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730320AbfB0OrR (ORCPT ); Wed, 27 Feb 2019 09:47:17 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:43227 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726389AbfB0OrR (ORCPT ); Wed, 27 Feb 2019 09:47:17 -0500 Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1gz0UG-0006Ys-U9; Wed, 27 Feb 2019 15:47:09 +0100 Received: from [IPv6:2a03:f580:87bc:d400:f8eb:aafc:4bc:24e5] (unknown [IPv6:2a03:f580:87bc:d400:f8eb:aafc:4bc:24e5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mkl@blackshift.org", Issuer "StartCom Class 1 Client CA" (not verified)) (Authenticated sender: mkl@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id E52E53DC78D; Wed, 27 Feb 2019 14:47:05 +0000 (UTC) To: Pavel Pisa , devicetree@vger.kernel.org Cc: Wolfgang Grandegger , "David S. Miller" , Rob Herring , Mark Rutland , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Martin Jerabek , Ondrej Ille References: <201902221420.05267.pisa@cmp.felk.cvut.cz> From: Marc Kleine-Budde Openpgp: preference=signencrypt Autocrypt: addr=mkl@pengutronix.de; prefer-encrypt=mutual; keydata= mQINBFFVq30BEACtnSvtXHoeHJxG6nRULcvlkW6RuNwHKmrqoksispp43X8+nwqIFYgb8UaX zu8T6kZP2wEIpM9RjEL3jdBjZNCsjSS6x1qzpc2+2ivjdiJsqeaagIgvy2JWy7vUa4/PyGfx QyUeXOxdj59DvLwAx8I6hOgeHx2X/ntKAMUxwawYfPZpP3gwTNKc27dJWSomOLgp+gbmOmgc 6U5KwhAxPTEb3CsT5RicsC+uQQFumdl5I6XS+pbeXZndXwnj5t84M+HEj7RN6bUfV2WZO/AB Xt5+qFkC/AVUcj/dcHvZwQJlGeZxoi4veCoOT2MYqfR0ax1MmN+LVRvKm29oSyD4Ts/97cbs XsZDRxnEG3z/7Winiv0ZanclA7v7CQwrzsbpCv+oj+zokGuKasofzKdpywkjAfSE1zTyF+8K nxBAmzwEqeQ3iKqBc3AcCseqSPX53mPqmwvNVS2GqBpnOfY7Mxr1AEmxdEcRYbhG6Xdn+ACq Dq0Db3A++3PhMSaOu125uIAIwMXRJIzCXYSqXo8NIeo9tobk0C/9w3fUfMTrBDtSviLHqlp8 eQEP8+TDSmRP/CwmFHv36jd+XGmBHzW5I7qw0OORRwNFYBeEuiOIgxAfjjbLGHh9SRwEqXAL kw+WVTwh0MN1k7I9/CDVlGvc3yIKS0sA+wudYiselXzgLuP5cQARAQABtCZNYXJjIEtsZWlu ZS1CdWRkZSA8bWtsQHBlbmd1dHJvbml4LmRlPokCVAQTAQoAPgIbAwIeAQIXgAULCQgHAwUV CgkICwUWAgMBABYhBMFAC6CzmJ5vvH1bXCte4hHFiupUBQJcUsSbBQkM366zAAoJECte4hHF iupUgkAP/2RdxKPZ3GMqag33jKwKAbn/fRqAFWqUH9TCsRH3h6+/uEPnZdzhkL4a9p/6OeJn Z6NXqgsyRAOTZsSFcwlfxLNHVxBWm8pMwrBecdt4lzrjSt/3ws2GqxPsmza1Gs61lEdYvLST Ix2vPbB4FAfE0kizKAjRZzlwOyuHOr2ilujDsKTpFtd8lV1nBNNn6HBIBR5ShvJnwyUdzuby tOsSt7qJEvF1x3y49bHCy3uy+MmYuoEyG6zo9udUzhVsKe3hHYC2kfB16ZOBjFC3lH2U5An+ yQYIIPZrSWXUeKjeMaKGvbg6W9Oi4XEtrwpzUGhbewxCZZCIrzAH2hz0dUhacxB201Y/faY6 BdTS75SPs+zjTYo8yE9Y9eG7x/lB60nQjJiZVNvZ88QDfVuLl/heuIq+fyNajBbqbtBT5CWf mOP4Dh4xjm3Vwlz8imWW/drEVJZJrPYqv0HdPbY8jVMpqoe5jDloyVn3prfLdXSbKPexlJaW 5tnPd4lj8rqOFShRnLFCibpeHWIumqrIqIkiRA9kFW3XMgtU6JkIrQzhJb6Tc6mZg2wuYW0d Wo2qvdziMgPkMFiWJpsxM9xPk9BBVwR+uojNq5LzdCsXQ2seG0dhaOTaaIDWVS8U/V8Nqjrl 6bGG2quo5YzJuXKjtKjZ4R6k762pHJ3tnzI/jnlc1sXzuQENBFxSzJYBCAC58uHRFEjVVE3J 31eyEQT6H1zSFCccTMPO/ewwAnotQWo98Bc67ecmprcnjRjSUKTbyY/eFxS21JnC4ZB0pJKx MNwK6zq71wLmpseXOgjufuG3kvCgwHLGf/nkBHXmSINHvW00eFK/kJBakwHEbddq8Dr4ewmr G7yr8d6A3CSn/qhOYWhIxNORK3SVo4Io7ExNX/ljbisGsgRzsWvY1JlN4sabSNEr7a8YaqTd 2CfFe/5fPcQRGsfhAbH2pVGigr7JddONJPXGE7XzOrx5KTwEv19H6xNe+D/W3FwjZdO4TKIo vcZveSDrFWOi4o2Te4O5OB/2zZbNWPEON8MaXi9zABEBAAGJA3IEGAEKACYWIQTBQAugs5ie b7x9W1wrXuIRxYrqVAUCXFLMlgIbAgUJAeKNmgFACRArXuIRxYrqVMB0IAQZAQoAHRYhBJrx JF84Dn3PPNRrhVrGIaOR5J0gBQJcUsyWAAoJEFrGIaOR5J0grw4H/itil/yryJCvzi6iuZHS suSHHOiEf+UQHib1MLP96LM7FmDabjVSmJDpH4TsMu17A0HTG+bPMAdeia0+q9FWSvSHYW8D wNhfkb8zojpa37qBpVpiNy7r6BKGSRSoFOv6m/iIoRJuJ041AEKao6djj/FdQF8OV1EtWKRO +nE2bNuDCcwHkhHP+FHExdzhKSmnIsMjGpGwIQKN6DxlJ7fN4W7UZFIQdSO21ei+akinBo4K O0uNCnVmePU1UzrwXKG2sS2f97A+sZE89vkc59NtfPHhofI3JkmYexIF6uqLA3PumTqLQ2Lu bywPAC3YNphlhmBrG589p+sdtwDQlpoH9O7NeBAAg/lyGOUUIONrheii/l/zR0xxr2TDE6tq 6HZWdtjWoqcaky6MSyJQIeJ20AjzdV/PxMkd8zOijRVTnlK44bcfidqFM6yuT1bvXAO6NOPy pvBRnfP66L/xECnZe7s07rXpNFy72XGNZwhj89xfpK4a9E8HQcOD0mNtCJaz7TTugqBOsQx2 45VPHosmhdtBQ6/gjlf2WY9FXb5RyceeSuK4lVrz9uZB+fUHBge/giOSsrqFo/9fWAZsE67k 6Mkdbpc7ZQwxelcpP/giB9N+XAfBsffQ8q6kIyuFV4ILsIECCIA4nt1rYmzphv6t5J6PmlTq TzW9jNzbYANoOFAGnjzNRyc9i8UiLvjhTzaKPBOkQfhStEJaZrdSWuR/7Tt2wZBBoNTsgNAw A+cEu+SWCvdX7vNpsCHMiHtcEmVt5R0Tex1Ky87EfXdnGR2mDi6Iyxi3MQcHez3C61Ga3Baf P8UtXR6zrrrlX22xXtpNJf4I4Z6RaLpB/avIXTFXPbJ8CUUbVD2R2mZ/jyzaTzgiABDZspbS gw17QQUrKqUog0nHXuaGGA1uvreHTnyBWx5P8FP7rhtvYKhw6XdJ06ns+2SFcQv0Bv6PcSDK aRXmnW+OsDthn84x1YkfGIRJEPvvmiOKQsFEiB4OUtTX2pheYmZcZc81KFfJMmE8Z9+LT6Ry uSS5AQ0EXFLNDgEIAL14qAzTMCE1PwRrYJRI/RSQGAGF3HLdYvjbQd9Ozzg02K3mNCF2Phb1 cjsbMk/V6WMxYoZCEtCh4X2GjQG2GDDW4KC9HOa8cTmr9Vcno+f+pUle09TMzWDgtnH92WKx d0FIQev1zDbxU7lk1dIqyOjjpyhmR8Put6vgunvuIjGJ/GapHL/O0yjVlpumtmow6eME2muc TeJjpapPWBGcy/8VU4LM8xMeMWv8DtQML5ogyJxZ0Smt+AntIzcF9miV2SeYXA3OFiojQstF vScN7owL1XiQ3UjJotCp6pUcSVgVv0SgJXbDo5Nv87M2itn68VPfTu2uBBxRYqXQovsR++kA EQEAAYkCPAQYAQoAJhYhBMFAC6CzmJ5vvH1bXCte4hHFiupUBQJcUs0OAhsMBQkB4o0iAAoJ ECte4hHFiupUbioQAJ40bEJmMOF28vFcGvQrpI+lfHJGk9zSrh4F4SlJyOVWV1yWyUAINr8w v1aamg2nAppZ16z4nAnGU/47tWZ4P8blLVG8x4SWzz3D7MCy1FsQBTrWGLqWldPhkBAGp2VH xDOK4rLhuQWx3H5zd3kPXaIgvHI3EliWaQN+u2xmTQSJN75I/V47QsaPvkm4TVe3JlB7l1Fg OmSvYx31YC+3slh89ayjPWt8hFaTLnB9NaW9bLhs3E2ESF9Dei0FRXIt3qnFV/hnETsx3X4h KEnXxhSRDVeURP7V6P/z3+WIfddVKZk5ZLHi39fJpxvsg9YLSfStMJ/cJfiPXk1vKdoa+FjN 7nGAZyF6NHTNhsI7aHnvZMDavmAD3lK6CY+UBGtGQA3QhrUc2cedp1V53lXwor/D/D3Wo9wY iSXKOl4fFCh2Peo7qYmFUaDdyiCxvFm+YcIeMZ8wO5udzkjDtP4lWKAn4tUcdcwMOT5d0I3q WATP4wFI8QktNBqF3VY47HFwF9PtNuOZIqeAquKezywUc5KqKdqEWCPx9pfLxBAh3GW2Zfjp lP6A5upKs2ktDZOC2HZXP4IJ1GTk8hnfS4ade8s9FNcwu9m3JlxcGKLPq5DnIbPVQI1UUR4F QyAqTtIdSpeFYbvH8D7pO4lxLSz2ZyBMk+aKKs6GL5MqEci8OcFW Subject: Re: [PATCH] dt-bindings: net: can: binding for CTU CAN FD open-source IP core. Message-ID: Date: Wed, 27 Feb 2019 15:47:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <201902221420.05267.pisa@cmp.felk.cvut.cz> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zXEJeE1ITuIOqdCWX0TUTCelucyuEsGc3" X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: netdev@vger.kernel.org Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --zXEJeE1ITuIOqdCWX0TUTCelucyuEsGc3 Content-Type: multipart/mixed; boundary="QnSscz5Zs0qqsxAkkiEaKOvhQZGotQDuG"; protected-headers="v1" From: Marc Kleine-Budde To: Pavel Pisa , devicetree@vger.kernel.org Cc: Wolfgang Grandegger , "David S. Miller" , Rob Herring , Mark Rutland , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Martin Jerabek , Ondrej Ille Message-ID: Subject: Re: [PATCH] dt-bindings: net: can: binding for CTU CAN FD open-source IP core. References: <201902221420.05267.pisa@cmp.felk.cvut.cz> In-Reply-To: <201902221420.05267.pisa@cmp.felk.cvut.cz> --QnSscz5Zs0qqsxAkkiEaKOvhQZGotQDuG Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: quoted-printable On 2/22/19 2:20 PM, Pavel Pisa wrote: > From 3e19a7f5c33e5fb50f52c9df05bf00022e3f3dd5 Mon Sep 17 00:00:00 2001 > From: Pavel Pisa > Date: Fri, 22 Feb 2019 14:11:11 +0100 > Subject: [PATCH] dt-bindings: net: can: binding for CTU CAN FD open-sou= rce IP > core. Nice! I appreciate open-source hardware! Please send the patch via git send-email, it's a bit broken: Applying: dt-bindings: net: can: binding for CTU CAN FD open-source IP co= re. =2Egit/rebase-apply/patch:29: trailing whitespace. error: corrupt patch at line 30 Patch failed at 0001 dt-bindings: net: can: binding for CTU CAN FD open-source IP core. hint: Use 'git am --show-current-patch' to see the failed patch > Signed-off-by: Pavel Pisa > --- > .../devicetree/bindings/net/can/ctu,ctucanfd.txt | 102 +++++++++++++= ++++++++ > 1 file changed, 102 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/can/ctu,ctuca= nfd.txt >=20 > diff --git a/Documentation/devicetree/bindings/net/can/ctu,ctucanfd.txt= =20 > b/Documentation/devicetree/bindings/net/can/ctu,ctucanfd.txt > new file mode 100644 > index 000000000000..6c75e5850904 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/can/ctu,ctucanfd.txt > @@ -0,0 +1,102 @@ > +Memory mapped CTU CAN FD open-source IP core > + > +The core sources and documentation on project page > + > + https://gitlab.fel.cvut.cz/canbus/ctucanfd_ip_core > + http://canbus.pages.fel.cvut.cz/ctucanfd_ip_core/Progdokum.pdf > + > +Integration in Xilinx Zynq SoC based system together with > +OpenCores SJA1000 compatible controllers > + > + https://gitlab.fel.cvut.cz/canbus/zynq/zynq-can-sja1000-top > + > +Martin Jerabek's dimploma thesis with integration and testing > +framework description > + > +=20 > https://dspace.cvut.cz/bitstream/handle/10467/80366/F3-DP-2019-Jerabek-= Martin-Jerabek-thesis-2019-canfd.pdf > + > +Required properties: > + > +- compatible : should be one of "ctu,ctucanfd", "ctu,canfd-2". > + > +- reg =3D <(baseaddr) (size)> : specify mapping into physical address > + space of the processor system. > + > +- interrupts : property with a value describing the interrupt source > + required for the CTU CAN FD. For Zynq SoC system format is > + <(is_spi) (number) (type)> where is_spi defines if it is SPI > + (shared peripheral) interrupt, the second number is translated > + to the vector by addition of 32 on Zynq-7000 systems and type > + is IRQ_TYPE_LEVEL_HIGH (4) for Zynq. > + > +- interrupt-parent =3D <&interrupt-controller-phandle> : > + is required for Zynq SoC to find map interrupt > + to the correct controller > + > +- clocks: phandle of reference clock (100 MHz is appropriate > + for FPGA implementation on Zynq-7000 system). > + > +Example when integrated to Zynq-7000 system DTS: > + > + / { > + /* ... */ > + amba: amba { > + #address-cells =3D <1>; > + #size-cells =3D <1>; > + compatible =3D "simple-bus"; > + > + CTU_CAN_FD_0: CTU_CAN_FD@43c30000 { It's unusual to have uppercase letters here. > + compatible =3D "ctu,ctucanfd"; Is ctu already registered in Documentation/devicetree/bindings/vendor-prefixes.txt ? > + interrupt-parent =3D <&intc>; > + interrupts =3D <0 30 4>; > + clocks =3D <&clkc 15>; > + reg =3D <0x43c30000 0x10000>; > + }; > + }; > + }; > + > + > +Example when used as DTS overlay on Zynq-7000 system: > + > + > +// Device Tree Example: Full Reconfiguration without Bridges > +/dts-v1/; > +/plugin/; > + > +/ { > + fragment@0 { > + target-path =3D "/fpga-full"; > + > + __overlay__ { > + #address-cells =3D <1>; > + #size-cells =3D <1>; > + > + firmware-name =3D "system.bit.bin"; > + }; > + }; > + > + fragment@1 { > + target-path =3D "/amba"; > + __overlay__ { > + #address-cells =3D <1>; > + #size-cells =3D <1>; > + > + CTU_CAN_FD_0: CTU_CAN_FD@43c30000 { > + compatible =3D "ctu,ctucanfd"; > + interrupt-parent =3D <&intc>; > + interrupts =3D <0 30 4>; > + clocks =3D <&clkc 15>; > + //clock-names =3D "can_clk"; Is this needed or not? > + reg =3D <0x43c30000 0x10000>; > + }; > + CTU_CAN_FD_1: CTU_CAN_FD@43c70000 { > + compatible =3D "ctu,ctucanfd"; > + interrupt-parent =3D <&intc>; > + interrupts =3D <0 31 4>; > + clocks =3D <&clkc 15>; > + //clock-names =3D "can_clk"; Is this needed or not? > + reg =3D <0x43c70000 0x10000>; > + }; > + }; > + }; > +}; >=20 Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --QnSscz5Zs0qqsxAkkiEaKOvhQZGotQDuG-- --zXEJeE1ITuIOqdCWX0TUTCelucyuEsGc3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEmvEkXzgOfc881GuFWsYho5HknSAFAlx2oucACgkQWsYho5Hk nSCZyggAmrE02FBYWH32e+Zyq4jzyQDmdlA1USNSxc6FgBIwTbeJKEnTTyYccuXt 9UVc7bmeqReE09pUALucpwb0icP7fTETNl7CIVivh+DF4IHkOLcu1qmf42DuLEwf RNoAfOXB/70XbuN1TDffI97YtAMxfxBDE0ZRSv1MnFL2Pb+oO7EvX852bLt7PO54 yIMQU6PzeM11W1SXAJnoDGDYU5Clo5SD+p35bcSFzui+h8fdh7Sr3Kc+HmDZ6iZ9 5v3jMhTi710D6LxrRttQ4DshX5zxH4Uqk2Y6Cttdh/UYXMfQUwRroBjSeBclxVs3 pSv/37EWnlKSlmuGTnXDQKKE8Awsyw== =fyDO -----END PGP SIGNATURE----- --zXEJeE1ITuIOqdCWX0TUTCelucyuEsGc3--