From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB123C43381 for ; Sat, 16 Feb 2019 23:22:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9075521925 for ; Sat, 16 Feb 2019 23:22:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LL4q3tTk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727633AbfBPXNR (ORCPT ); Sat, 16 Feb 2019 18:13:17 -0500 Received: from mail-pg1-f194.google.com ([209.85.215.194]:40260 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727173AbfBPXNQ (ORCPT ); Sat, 16 Feb 2019 18:13:16 -0500 Received: by mail-pg1-f194.google.com with SMTP id u9so3061701pgo.7 for ; Sat, 16 Feb 2019 15:13:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZDbAIuZuvRoFZOsBJm9a4oRXHEGkroaRYRyXK2qxMwU=; b=LL4q3tTkDau2CSMyDQCgPT/y4HRbCFLwkkPXQ454TR8UdVjJuz8J4yvxfr2bbZI5An EBEnp3QNLwGuXvBqaDjCCxFTFkjblFGJ/U2Sffp0jJq8yQ9HXI/wZdrQH8QU9BLAShMV 2OAeRz8SkJBHsblC8LCQKNndzhFS1k7u8FYioTXROwzolNKQoIehmu5Ky74bsXE7RNYv 2Yh/aI3t983uW1mBJUDZokAXyoH5+ujrQrUwauvwdm7ZC/pKByZTDmJzw4p2vBQd+zN6 VWzLLA4TfJf8bOOuCWouhWQLVjc8qBwmhNK7QD8Ht9Cvq1Da3DnfShcNt+12RgieNc1l IKsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZDbAIuZuvRoFZOsBJm9a4oRXHEGkroaRYRyXK2qxMwU=; b=WKw7ihrLOZy5APOwZvBUukabGNmDcwUIuAxJx1TlAhkokwcD935u/05Tt0jWQBmnd0 ab3hLZeSaDd/JPUgk8Usz2I3Bc4Uvgrv1Bgc9hDKamr8QLALfBfPuIWm3qNIpCroNXOc XcnoSAMZLfU59veT1wrC350w+pOHJLRJ+Zx6Ji/Kx7n7kfNx6FdwbnzjJt46S5T5qV6y BuVuj4CYPGozXDYu7tk3pWSvt9aH3Oc2QWNQyRxAaR644xUzFH5Z+/yjncwHkqbJS6WS kLLaPuv8chLcvwhhULr6FLNGCxzgGgMqQgEqFLbbh7chfq7Nr4PrzcS7kuiLHOIIdzBb enHg== X-Gm-Message-State: AHQUAubMa3Pqx8mfZ2/8VHsS+QLn79qRwFQfAvQSftJcw33X6A23HOBx 3VolQkgEZD85hqtZcjK93fM= X-Google-Smtp-Source: AHgI3IZOFiONI6bjm74nlnnROkkzUiBB7zEKUQbPBOUlAHzM2N781kNvx2aNfe1l81vaMG2uK/A/Eg== X-Received: by 2002:a63:4a4d:: with SMTP id j13mr12162204pgl.127.1550358795915; Sat, 16 Feb 2019 15:13:15 -0800 (PST) Received: from ?IPv6:2601:284:8200:5cfb:95b9:8d0c:ef0d:7720? ([2601:284:8200:5cfb:95b9:8d0c:ef0d:7720]) by smtp.googlemail.com with ESMTPSA id j197sm24083291pgc.76.2019.02.16.15.13.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 16 Feb 2019 15:13:15 -0800 (PST) Subject: Re: [PATCH bpf-next] selftests: bpf: test_lwt_ip_encap: add negative tests. To: Peter Oskolkov , Alexei Starovoitov , Daniel Borkmann , netdev@vger.kernel.org Cc: Peter Oskolkov References: <20190215234933.208398-1-posk@google.com> From: David Ahern Message-ID: Date: Sat, 16 Feb 2019 16:13:12 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190215234933.208398-1-posk@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/15/19 4:49 PM, Peter Oskolkov wrote: > @@ -178,7 +205,7 @@ set -e # exit on error > # configure IPv4 GRE device in NS3, and a route to it via the "bottom" route > ip -netns ${NS3} tunnel add gre_dev mode gre remote ${IPv4_1} local ${IPv4_GRE} ttl 255 > ip -netns ${NS3} link set gre_dev up > - ip -netns ${NS3} addr add ${IPv4_GRE} dev gre_dev > + ip -netns ${NS3} addr add ${IPv4_GRE} nodad dev gre_dev nodad is only effective for IPv6. other than that LGTM. Thanks for the update. Reviewed-by: David Ahern