From: Saeed Mahameed <saeed@kernel.org>
To: Anmol Karn <anmol.karan123@gmail.com>,
ralf@linux-mips.org, davem@davemloft.net, kuba@kernel.org
Cc: gregkh@linuxfoundation.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hams@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
syzkaller-bugs@googlegroups.com,
syzbot+a1c743815982d9496393@syzkaller.appspotmail.com
Subject: Re: [Linux-kernel-mentees] [PATCH v2 net] rose: Fix Null pointer dereference in rose_send_frame()
Date: Fri, 06 Nov 2020 13:04:27 -0800 [thread overview]
Message-ID: <b97dc3f0843cc2b7d7674dbd467ad5ba40824ba3.camel@kernel.org> (raw)
In-Reply-To: <20201105155600.9711-1-anmol.karan123@gmail.com>
On Thu, 2020-11-05 at 21:26 +0530, Anmol Karn wrote:
> rose_send_frame() dereferences `neigh->dev` when called from
> rose_transmit_clear_request(), and the first occurance of the `neigh`
> is in rose_loopback_timer() as `rose_loopback_neigh`, and it is
> initialized
> in rose_add_loopback_neigh() as NULL. i.e when `rose_loopback_neigh`
> used in
> rose_loopback_timer() its `->dev` was still NULL and
> rose_loopback_timer()
> was calling rose_rx_call_request() without checking for NULL.
>
> - net/rose/rose_link.c
> This bug seems to get triggered in this line:
>
> rose_call = (ax25_address *)neigh->dev->dev_addr;
>
> Fix it by adding NULL checking for `rose_loopback_neigh->dev` in
> rose_loopback_timer().
>
> Reported-and-tested-by:
> syzbot+a1c743815982d9496393@syzkaller.appspotmail.com
> Link:
> https://syzkaller.appspot.com/bug?id=9d2a7ca8c7f2e4b682c97578dfa3f236258300b3
>
> Signed-off-by: Anmol Karn <anmol.karan123@gmail.com>
missing proper fixes tag.
> ---
> net/rose/rose_loopback.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/rose/rose_loopback.c b/net/rose/rose_loopback.c
> index 7b094275ea8b..cd7774cb1d07 100644
> --- a/net/rose/rose_loopback.c
> +++ b/net/rose/rose_loopback.c
> @@ -96,7 +96,7 @@ static void rose_loopback_timer(struct timer_list
> *unused)
> }
>
> if (frametype == ROSE_CALL_REQUEST) {
> - if ((dev = rose_dev_get(dest)) != NULL) {
> + if (rose_loopback_neigh->dev && (dev =
> rose_dev_get(dest)) != NULL) {
> if (rose_rx_call_request(skb, dev,
> rose_loopback_neigh, lci_o) == 0)
> kfree_skb(skb);
> } else {
check patch is not happy:
WARNING:TYPO_SPELLING: 'occurance' may be misspelled - perhaps
'occurrence'?
#7:
rose_transmit_clear_request(), and the first occurance of the `neigh`
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#36: FILE: net/rose/rose_loopback.c:99:
+ if (rose_loopback_neigh->dev && (dev =
rose_dev_get(dest)) != NULL) {
total: 1 errors, 1 warnings, 0 checks, 8 lines checked
next prev parent reply other threads:[~2020-11-06 21:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 15:56 [Linux-kernel-mentees] [PATCH v2 net] rose: Fix Null pointer dereference in rose_send_frame() Anmol Karn
2020-11-06 21:04 ` Saeed Mahameed [this message]
2020-11-07 8:20 ` Anmol Karn
2020-11-07 19:18 ` [Linux-kernel-mentees] [PATCH v3 " Anmol Karn
2020-11-10 17:58 ` Jakub Kicinski
2020-11-10 19:45 ` Anmol Karn
2020-11-11 16:59 ` [Linux-kernel-mentees] [PATCH v4 " Anmol Karn
2020-11-14 19:18 ` Jakub Kicinski
2020-11-15 11:44 ` Anmol Karn
2020-11-19 19:10 ` [Linux-kernel-mentees] [PATCH v5 " Anmol Karn
2020-11-20 18:06 ` Jakub Kicinski
2020-11-07 18:56 ` [Linux-kernel-mentees] [PATCH v2] net: " Anmol Karn
2020-11-07 19:02 ` Anmol karn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b97dc3f0843cc2b7d7674dbd467ad5ba40824ba3.camel@kernel.org \
--to=saeed@kernel.org \
--cc=anmol.karan123@gmail.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-hams@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=syzbot+a1c743815982d9496393@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).