From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DFD8C4708A for ; Thu, 27 May 2021 16:52:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1C677613B5 for ; Thu, 27 May 2021 16:52:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236489AbhE0QyL (ORCPT ); Thu, 27 May 2021 12:54:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234203AbhE0QyJ (ORCPT ); Thu, 27 May 2021 12:54:09 -0400 Received: from mail-ed1-x562.google.com (mail-ed1-x562.google.com [IPv6:2a00:1450:4864:20::562]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14CD5C061574 for ; Thu, 27 May 2021 09:52:35 -0700 (PDT) Received: by mail-ed1-x562.google.com with SMTP id s6so1599966edu.10 for ; Thu, 27 May 2021 09:52:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flowbird.group; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=mWC0KOOb2mz4yNzyrkqwQS6Vzaaz4jcMPp0At66McsM=; b=SEmjWPgdibLJX/K6hE5J3GzLbpt+qL8epkfMXiYPJc7u7mcS46/lPMJTpYU1X+HGk5 rmw59rW3UykXpTpUfr3bBPMoDRsZE7CCIEARjAnNJjEmgesFfeMWRcQ2x5L0xKuMmHWC X0lGk4EvOowIMK2SublKkFf1FNkmqcPKh2aqqFeQyA3h/6JonijkNDpKaXB1UVcHhsrZ bCVUfgkPh4pa799sTlBZRholLpy6kJtIp+MKXq4v2mlsdCTgKQi3dLXs6DY4BdO2BkXm 54otYxRfQEMFNBRmsYTKqHulUTYI3FD2FWSN/mmKbLDWjZd//ZEZeSkopuNz110EXPyG fovw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=mWC0KOOb2mz4yNzyrkqwQS6Vzaaz4jcMPp0At66McsM=; b=VtLJ9UbST04Q5zmX8r21HE7mkQPCt5WPckwdLwhQO2H7vr0pKZWv4m+Dp+LTqRAEv8 X8x8uzXW0JCGQjR0NtM0D5xK5zvKVewmlCrcAOzOmeBqbU8oDSOzAxyeiez2i63GefRg sFJq/yU8uHKeT0hmyGzR+rMoqGGA+mFCtV31urywr9ym/yt3y1f6e/9wV/ekFjsmT9l7 n0A8SgJlAzXk8fFyEKr5TuQCg1CwLPkzhKyIbiOS5bIsgmKiN7I0KMQKlZVDAlYnFDB2 zRBNbXrpGSOSbp3wLmWRiz30NbpSi7YfuFdz7hbSEdUPp9jBDKNa8juo3mDai2jRxAs2 33ww== X-Gm-Message-State: AOAM531eySQKKTWs1kIB6wr4Iyfl6rRLdTND/WGTUuEfUCx/IQXFjxvm PD7jZnKtuAjHEGSJKYnzaMsAqlTYVYcU56g9MyUdLzsz+TLY X-Google-Smtp-Source: ABdhPJyRIDcn/nCOOhoQLXK46urvwnpEOOHEMTjbOX1XNK4pPO1S62BevGgpHEcSUkbVlCvvwNtcTWaVzcxn X-Received: by 2002:a05:6402:50d1:: with SMTP id h17mr5446344edb.199.1622134353381; Thu, 27 May 2021 09:52:33 -0700 (PDT) Received: from mta1.parkeon.com ([185.149.63.251]) by smtp-relay.gmail.com with ESMTPS id w11sm210974ede.8.2021.05.27.09.52.33 (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 27 May 2021 09:52:33 -0700 (PDT) X-Relaying-Domain: flowbird.group Received: from [172.16.13.122] (port=32794) by mta1.parkeon.com with esmtp (Exim 4.71) (envelope-from ) id 1lmJFI-00089q-UK; Thu, 27 May 2021 18:52:33 +0200 Subject: Re: [PATCH] rsi: Fix TX EAPOL packet handling against iwlwifi AP To: Marek Vasut , netdev@vger.kernel.org Cc: Angus Ainslie , "David S . Miller" , Jakub Kicinski , Kalle Valo , Lee Jones , Martin Kepplinger , Sebastian Krzyszkowiak , Siva Rebbagondla , linux-wireless@vger.kernel.org References: <20201015111616.429220-1-marex@denx.de> From: Martin Fuzzey Message-ID: Date: Thu, 27 May 2021 18:52:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20201015111616.429220-1-marex@denx.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: fr Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Marek, I've just run into the same problem (on -5.4) and found your (now merged) patch On 15/10/2020 13:16, Marek Vasut wrote: > In case RSI9116 SDIO WiFi operates in STA mode against Intel 9260 in AP mode, > the association fails. The former is using wpa_supplicant during association, > the later is set up using hostapd: > > iwl$ cat hostapd.conf > interface=wlp1s0 > ssid=test > country_code=DE > hw_mode=g > channel=1 > wpa=2 > wpa_passphrase=test > wpa_key_mgmt=WPA-PSK > iwl$ hostapd -d hostapd.conf > > rsi$ wpa_supplicant -i wlan0 -c <(wpa_passphrase test test) > > The problem is that the TX EAPOL data descriptor RSI_DESC_REQUIRE_CFM_TO_HOST > flag and extended descriptor EAPOL4_CONFIRM frame type are not set in case the > AP is iwlwifi, because in that case the TX EAPOL packet is 2 bytes shorter. > > The downstream vendor driver has this change in place already [1], however > there is no explanation for it, neither is there any commit history from which > such explanation could be obtained. > I get this using 2 RSI9116 s, for both AP and STA using hostapd. Comparing packet captures in the working and non working (without your patch) case shows that the working case has a 802.11 QOS header whereas the non working case does not, hence the 2 byte difference. The size of the EAPOL data is the same, it's the previous header that causes the problem... This whole use the message size to determine the messages to ACK seems very fragile... Regards, Martin