From: Shannon Nelson <snelson@pensando.io>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH v6 net-next 07/19] ionic: Add basic adminq support
Date: Fri, 30 Aug 2019 12:31:07 -0700 [thread overview]
Message-ID: <bad39320-8e67-e280-5e35-612cbdc49b6f@pensando.io> (raw)
In-Reply-To: <20190829155251.3b2d86c7@cakuba.netronome.com>
On 8/29/19 3:52 PM, Jakub Kicinski wrote:
> On Thu, 29 Aug 2019 11:27:08 -0700, Shannon Nelson wrote:
>> +static void ionic_lif_qcq_deinit(struct ionic_lif *lif, struct ionic_qcq *qcq)
>> +{
>> + struct ionic_dev *idev = &lif->ionic->idev;
>> + struct device *dev = lif->ionic->dev;
>> +
>> + if (!qcq)
>> + return;
>> +
>> + ionic_debugfs_del_qcq(qcq);
>> +
>> + if (!(qcq->flags & IONIC_QCQ_F_INITED))
>> + return;
>> +
>> + if (qcq->flags & IONIC_QCQ_F_INTR) {
>> + ionic_intr_mask(idev->intr_ctrl, qcq->intr.index,
>> + IONIC_INTR_MASK_SET);
>> + synchronize_irq(qcq->intr.vector);
>> + devm_free_irq(dev, qcq->intr.vector, &qcq->napi);
> Doesn't free_irq() basically imply synchronize_irq()?
The synchronize_irq() waits for any threaded handlers to finish, while
free_irq() only waits for HW handling. This helps makes sure we don't
have anything still running before we remove resources.
sln
>
>> + netif_napi_del(&qcq->napi);
>> + }
>> +
>> + qcq->flags &= ~IONIC_QCQ_F_INITED;
next prev parent reply other threads:[~2019-08-30 19:31 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 18:27 [PATCH v6 net-next 00/19] ionic: Add ionic driver Shannon Nelson
2019-08-29 18:27 ` [PATCH v6 net-next 01/19] devlink: Add new info version tags for ASIC and FW Shannon Nelson
2019-08-29 22:33 ` Jakub Kicinski
2019-08-29 18:27 ` [PATCH v6 net-next 02/19] ionic: Add basic framework for IONIC Network device driver Shannon Nelson
2019-08-29 22:38 ` Jakub Kicinski
2019-08-30 19:02 ` Shannon Nelson
2019-08-29 18:27 ` [PATCH v6 net-next 03/19] ionic: Add hardware init and device commands Shannon Nelson
2019-08-29 18:27 ` [PATCH v6 net-next 04/19] ionic: Add port management commands Shannon Nelson
2019-08-29 22:46 ` Jakub Kicinski
2019-08-30 19:18 ` Shannon Nelson
2019-08-29 18:27 ` [PATCH v6 net-next 05/19] ionic: Add basic lif support Shannon Nelson
2019-08-29 18:27 ` [PATCH v6 net-next 06/19] ionic: Add interrupts and doorbells Shannon Nelson
2019-08-29 18:27 ` [PATCH v6 net-next 07/19] ionic: Add basic adminq support Shannon Nelson
2019-08-29 22:52 ` Jakub Kicinski
2019-08-30 19:31 ` Shannon Nelson [this message]
2019-08-30 22:16 ` Jakub Kicinski
2019-08-30 22:17 ` David Miller
2019-08-30 23:18 ` Shannon Nelson
2019-08-29 18:27 ` [PATCH v6 net-next 08/19] ionic: Add adminq action Shannon Nelson
2019-08-29 18:27 ` [PATCH v6 net-next 09/19] ionic: Add notifyq support Shannon Nelson
2019-08-29 18:27 ` [PATCH v6 net-next 10/19] ionic: Add the basic NDO callbacks for netdev support Shannon Nelson
2019-08-29 18:27 ` [PATCH v6 net-next 11/19] ionic: Add management of rx filters Shannon Nelson
2019-08-29 18:27 ` [PATCH v6 net-next 12/19] ionic: Add Rx filter and rx_mode ndo support Shannon Nelson
2019-08-29 23:06 ` Jakub Kicinski
2019-08-30 19:35 ` Shannon Nelson
2019-08-29 18:27 ` [PATCH v6 net-next 13/19] ionic: Add async link status check and basic stats Shannon Nelson
2019-08-29 18:27 ` [PATCH v6 net-next 14/19] ionic: Add initial ethtool support Shannon Nelson
2019-08-29 23:10 ` Jakub Kicinski
2019-08-30 21:25 ` Shannon Nelson
2019-08-30 22:16 ` Jakub Kicinski
2019-09-01 19:52 ` Andrew Lunn
2019-08-29 18:27 ` [PATCH v6 net-next 15/19] ionic: Add Tx and Rx handling Shannon Nelson
2019-08-29 23:18 ` Jakub Kicinski
2019-08-30 23:57 ` Shannon Nelson
2019-08-29 23:33 ` Jakub Kicinski
2019-08-30 21:44 ` Shannon Nelson
2019-08-30 22:21 ` Jakub Kicinski
2019-08-29 18:27 ` [PATCH v6 net-next 16/19] ionic: Add netdev-event handling Shannon Nelson
2019-08-29 23:37 ` Jakub Kicinski
2019-08-30 21:36 ` Shannon Nelson
2019-08-30 22:24 ` Jakub Kicinski
2019-08-29 18:27 ` [PATCH v6 net-next 17/19] ionic: Add driver stats Shannon Nelson
2019-08-29 18:27 ` [PATCH v6 net-next 18/19] ionic: Add RSS support Shannon Nelson
2019-08-29 18:27 ` [PATCH v6 net-next 19/19] ionic: Add coalesce and other features Shannon Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bad39320-8e67-e280-5e35-612cbdc49b6f@pensando.io \
--to=snelson@pensando.io \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).