From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 1/6] ravb: remove custom .nway_reset from ethtool ops Date: Sat, 26 May 2018 20:51:35 +0300 Message-ID: References: <1527160318-10958-1-git-send-email-vladimir_zapolskiy@mentor.com> <1527160318-10958-2-git-send-email-vladimir_zapolskiy@mentor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org To: Vladimir Zapolskiy , "David S. Miller" Return-path: Received: from mail-wm0-f68.google.com ([74.125.82.68]:35102 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032115AbeEZRvh (ORCPT ); Sat, 26 May 2018 13:51:37 -0400 Received: by mail-wm0-f68.google.com with SMTP id o78-v6so22327715wmg.0 for ; Sat, 26 May 2018 10:51:37 -0700 (PDT) In-Reply-To: <1527160318-10958-2-git-send-email-vladimir_zapolskiy@mentor.com> Content-Language: en-MW Sender: netdev-owner@vger.kernel.org List-ID: On 05/24/2018 02:11 PM, Vladimir Zapolskiy wrote: > The change fixes a sleep in atomic context issue, which can be > always triggered by running 'ethtool -r' command, because > phy_start_aneg() protects phydev fields by a mutex. BTW, I was unable to trigger the BUG() with 'ethtool -r eth0' where 'eth0' is EtherAVB. What am I doing wrong? :-) MBR, Sergei