From: Shannon Nelson <snelson@pensando.io>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH v2 net-next 07/12] ionic: reduce contiguous memory allocation requirement
Date: Thu, 27 Aug 2020 12:53:17 -0700 [thread overview]
Message-ID: <bd9b0427-6772-068e-d7bd-b1aabf1ac6ed@pensando.io> (raw)
In-Reply-To: <20200827124625.511ef647@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 8/27/20 12:46 PM, Jakub Kicinski wrote:
> On Thu, 27 Aug 2020 11:07:30 -0700 Shannon Nelson wrote:
>> + q_base = (void *)PTR_ALIGN((uintptr_t)new->q_base, PAGE_SIZE);
> The point of PTR_ALIGN is to make the casts unnecessary. Does it not
> work?
Here's what I see from two different compiler versions:
drivers/net/ethernet/pensando/ionic/ionic_lif.c:514:9: warning:
assignment makes pointer from integer without a cast [-Wint-conversion]
q_base = PTR_ALIGN((uintptr_t)new->q_base, PAGE_SIZE);
drivers/net/ethernet/pensando/ionic/ionic_lif.c:514:9: warning:
assignment to 'void *' from 'long unsigned int' makes pointer from
integer without a cast [-Wint-conversion]
q_base = PTR_ALIGN((uintptr_t)new->q_base, PAGE_SIZE);
sln
next prev parent reply other threads:[~2020-08-27 19:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 18:07 [PATCH v2 net-next 00/12] ionic memory usage rework Shannon Nelson
2020-08-27 18:07 ` [PATCH v2 net-next 01/12] ionic: set MTU floor at ETH_MIN_MTU Shannon Nelson
2020-08-27 18:07 ` [PATCH v2 net-next 02/12] ionic: fix up a couple of debug strings Shannon Nelson
2020-08-27 18:07 ` [PATCH v2 net-next 03/12] ionic: use kcalloc for new arrays Shannon Nelson
2020-08-27 18:07 ` [PATCH v2 net-next 04/12] ionic: remove lif list concept Shannon Nelson
2020-08-27 18:07 ` [PATCH v2 net-next 05/12] ionic: rework and simplify handling of the queue stats block Shannon Nelson
2020-08-27 18:07 ` [PATCH v2 net-next 06/12] ionic: clean up unnecessary non-static functions Shannon Nelson
2020-08-27 18:07 ` [PATCH v2 net-next 07/12] ionic: reduce contiguous memory allocation requirement Shannon Nelson
2020-08-27 19:46 ` Jakub Kicinski
2020-08-27 19:53 ` Shannon Nelson [this message]
2020-08-27 21:25 ` Jakub Kicinski
2020-08-27 22:58 ` Shannon Nelson
2020-08-27 19:47 ` Jakub Kicinski
2020-08-27 18:07 ` [PATCH v2 net-next 08/12] ionic: use index not pointer for queue tracking Shannon Nelson
2020-08-27 18:07 ` [PATCH v2 net-next 09/12] ionic: change mtu without full queue rebuild Shannon Nelson
2020-08-27 18:07 ` [PATCH v2 net-next 10/12] ionic: change the descriptor ring length without full reset Shannon Nelson
2020-08-27 18:07 ` [PATCH v2 net-next 11/12] ionic: change queue count with no reset Shannon Nelson
2020-08-27 18:07 ` [PATCH v2 net-next 12/12] ionic: pull reset_queues into tx_timeout handler Shannon Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd9b0427-6772-068e-d7bd-b1aabf1ac6ed@pensando.io \
--to=snelson@pensando.io \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).