From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DE51C31E58 for ; Mon, 17 Jun 2019 10:35:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E6E642084D for ; Mon, 17 Jun 2019 10:35:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="LbaodTzM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727523AbfFQKf4 (ORCPT ); Mon, 17 Jun 2019 06:35:56 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:43724 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726427AbfFQKfy (ORCPT ); Mon, 17 Jun 2019 06:35:54 -0400 Received: by mail-wr1-f67.google.com with SMTP id p13so9334960wru.10 for ; Mon, 17 Jun 2019 03:35:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=LdLD6/GLnt8m3EwyYjIGs7rafDrtX5c/RGMl/GKKl8o=; b=LbaodTzMAL8u12y2crGYXzc5LcEcD4olP+PnKNNkq1Ry/FFWYTKTvPDF4uTM6VXEOO Ok3b/58sc2ip+falSZ1Temq/KsMze8wnfJQLOklfCX2iBleXVj0ObJ1h1Mgls5NXnna/ SQSig9XOK4T0+hyMOxF8Xhmr/+4C1XqzOEM24= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LdLD6/GLnt8m3EwyYjIGs7rafDrtX5c/RGMl/GKKl8o=; b=LrBg87zYyZpWWAv1wFq0c0uaWXCu/ZTrwwe2+AT8MFV0/+aNr1WUbopFIf/RVTNJym qEAxUYAZHda8tAWkZc3G+cCcVH57nTTB8bmsrXANGc0W310jL1WTFewxOipactlp7oIX dIhLQ00IFjsz8bGg2rZOnpek5v4x1pSBYxtbdWR3dRCzFWs6/jkrU0DoAin1vrxbIIOW 6SXqCOltx1v2Q9u3ttd5l2SzOinR/PAfswysRVmMrbLrN+KNpMgqHtAYdIMyaAe9nL/b +zkFQJWfa/kYqrJkGGBLdxwgXMjavhZyLixumlW4XzAKju82e3Vo4nru+PlPiga2JXIg KEXQ== X-Gm-Message-State: APjAAAXlTNEBJsZsMgOw7b+3Rqt7Il20bezXlQ0jMEonq07CWR2e3kMD iqZ6nqXPQUu5Vl4gjHV2LZ4gyg== X-Google-Smtp-Source: APXvYqzFFb4lC949Z60IWxorsffQZyTfPYve5pAYlHt07baOm8aNcHW8hBKNaqDa+JDSAIdRNBcnyw== X-Received: by 2002:adf:f84f:: with SMTP id d15mr75042119wrq.53.1560767752500; Mon, 17 Jun 2019 03:35:52 -0700 (PDT) Received: from [10.176.68.244] ([192.19.248.250]) by smtp.gmail.com with ESMTPSA id p140sm3887001wme.31.2019.06.17.03.35.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Jun 2019 03:35:51 -0700 (PDT) Subject: Re: [PATCH v4 3/5] brcmfmac: sdio: Disable auto-tuning around commands expected to fail To: Douglas Anderson , Ulf Hansson , Kalle Valo , Adrian Hunter Cc: brcm80211-dev-list.pdl@broadcom.com, linux-rockchip@lists.infradead.org, Double Lo , briannorris@chromium.org, linux-wireless@vger.kernel.org, Naveen Gupta , Madhan Mohan R , mka@chromium.org, Wright Feng , Chi-Hsien Lin , netdev@vger.kernel.org, brcm80211-dev-list@cypress.com, Hans de Goede , Franky Lin , linux-kernel@vger.kernel.org, Hante Meuleman , YueHaibing , "David S. Miller" References: <20190613234153.59309-1-dianders@chromium.org> <20190613234153.59309-4-dianders@chromium.org> From: Arend Van Spriel Message-ID: Date: Mon, 17 Jun 2019 12:35:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: <20190613234153.59309-4-dianders@chromium.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 6/14/2019 1:41 AM, Douglas Anderson wrote: > There are certain cases, notably when transitioning between sleep and > active state, when Broadcom SDIO WiFi cards will produce errors on the > SDIO bus. This is evident from the source code where you can see that > we try commands in a loop until we either get success or we've tried > too many times. The comment in the code reinforces this by saying > "just one write attempt may fail" > > Unfortunately these failures sometimes end up causing an "-EILSEQ" > back to the core which triggers a retuning of the SDIO card and that > blocks all traffic to the card until it's done. > > Let's disable retuning around the commands we expect might fail. > > Fixes: bd11e8bd03ca ("mmc: core: Flag re-tuning is needed on CRC errors") Reviewed-by: Arend van Spriel > Signed-off-by: Douglas Anderson