Re: [PATCH v2] parisc: Make struct parisc_driver::remove() return void

From: Jiri Slaby <jirislaby@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	"Helge Deller" <deller@gmx.de>
Cc: kernel@pengutronix.de, alsa-devel@alsa-project.org,
	Corey Minyard <minyard@acm.org>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Takashi Iwai <tiwai@suse.com>,
	Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
	linux-scsi@vger.kernel.org, netdev@vger.kernel.org,
	linux-parisc@vger.kernel.org, linux-serial@vger.kernel.org,
	linux-input@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
	openipmi-developer@lists.sourceforge.net,
	Jaroslav Kysela <perex@perex.cz>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v2] parisc: Make struct parisc_driver::remove() return void
Date: Mon, 9 Aug 2021 06:19:34 +0200	[thread overview]
Message-ID: <bef58281-91b3-b2d6-ace8-afe0d08221e1@kernel.org> (raw)
In-Reply-To: <20210807091927.1974404-1-u.kleine-koenig@pengutronix.de>

On 07. 08. 21, 11:19, Uwe Kleine-König wrote:
> The caller of this function (parisc_driver_remove() in
> arch/parisc/kernel/drivers.c) ignores the return value, so better don't
> return any value at all to not wake wrong expectations in driver authors.
> 
> The only function that could return a non-zero value before was
> ipmi_parisc_remove() which returns the return value of
> ipmi_si_remove_by_dev(). Make this function return void, too, as for all
> other callers the value is ignored, too.
> 
> Also fold in a small checkpatch fix for:
> 
> WARNING: Unnecessary space before function pointer arguments
> +	void (*remove) (struct parisc_device *dev);
> 
> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> (for drivers/input)
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> changes since v1 sent with Message-Id:
> 20210806093938.1950990-1-u.kleine-koenig@pengutronix.de:
> 
>   - Fix a compiler error noticed by the kernel test robot
>   - Add Ack for Dmitry
> 
>   arch/parisc/include/asm/parisc-device.h  | 4 ++--
>   drivers/char/ipmi/ipmi_si.h              | 2 +-
>   drivers/char/ipmi/ipmi_si_intf.c         | 6 +-----
>   drivers/char/ipmi/ipmi_si_parisc.c       | 4 ++--
>   drivers/char/ipmi/ipmi_si_platform.c     | 4 +++-
>   drivers/input/keyboard/hilkbd.c          | 4 +---
>   drivers/input/serio/gscps2.c             | 3 +--
>   drivers/net/ethernet/i825xx/lasi_82596.c | 3 +--
>   drivers/parport/parport_gsc.c            | 3 +--
>   drivers/scsi/lasi700.c                   | 4 +---
>   drivers/scsi/zalon.c                     | 4 +---
>   drivers/tty/serial/mux.c                 | 3 +--

For the TTY piece:
Acked-by: Jiri Slaby <jirislaby@kernel.org>

thanks,
-- 
-- 
js
suse labs