From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Richard Palethorpe <rpalethorpe@suse.com>, linux-can@vger.kernel.org
Cc: Kees Cook <keescook@chromium.org>,
netdev@vger.kernel.org, security@kernel.org, wg@grandegger.com,
davem@davemloft.net
Subject: Re: [PATCH v2] slcan: Don't transmit uninitialized stack data in padding
Date: Wed, 1 Apr 2020 12:08:02 +0200 [thread overview]
Message-ID: <bf943fd5-277f-075c-a4c7-d52c2c816e7a@pengutronix.de> (raw)
In-Reply-To: <20200401100639.20199-1-rpalethorpe@suse.com>
On 4/1/20 12:06 PM, Richard Palethorpe wrote:
> struct can_frame contains some padding which is not explicitly zeroed in
> slc_bump. This uninitialized data will then be transmitted if the stack
> initialization hardening feature is not enabled (CONFIG_INIT_STACK_ALL).
>
> This commit just zeroes the whole struct including the padding.
>
> Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com>
> Fixes: a1044e36e457 ("can: add slcan driver for serial/USB-serial CAN adapters")
> Reviewed-by: Kees Cook <keescook@chromium.org>
> Cc: linux-can@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Cc: security@kernel.org
> Cc: wg@grandegger.com
> Cc: mkl@pengutronix.de
> Cc: davem@davemloft.net
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2020-04-01 10:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 10:06 [PATCH v2] slcan: Don't transmit uninitialized stack data in padding Richard Palethorpe
2020-04-01 10:08 ` Marc Kleine-Budde [this message]
2020-04-01 18:23 ` David Miller
2020-04-01 19:41 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf943fd5-277f-075c-a4c7-d52c2c816e7a@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=davem@davemloft.net \
--cc=keescook@chromium.org \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rpalethorpe@suse.com \
--cc=security@kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).