From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C226EC433E0 for ; Mon, 8 Feb 2021 15:43:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C18164E50 for ; Mon, 8 Feb 2021 15:43:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233861AbhBHPnW (ORCPT ); Mon, 8 Feb 2021 10:43:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234033AbhBHPm1 (ORCPT ); Mon, 8 Feb 2021 10:42:27 -0500 Received: from mail-oo1-xc31.google.com (mail-oo1-xc31.google.com [IPv6:2607:f8b0:4864:20::c31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D58C6C061788; Mon, 8 Feb 2021 07:41:46 -0800 (PST) Received: by mail-oo1-xc31.google.com with SMTP id q4so3526169ood.8; Mon, 08 Feb 2021 07:41:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=sxdNpbaxjlgrI7y1xjMXjF7UFp2IQQ7kDEnaAjSJx9g=; b=YfIiYx/BKZ4rZeX8RpLOTQsQ/KtLpC8M6vxPN/XhchXntph3d2A7qVunw33G3PREa0 F+D2/WFlIa/yxvdNhzJ9UufatBB0/30XR7OCSbrAuPtQySZh6fH0VlX+20Q5nP8rbqt9 MqOz/KG5w9mdSYoW08j54YMvejJIKhVcHGQGR6c1beANVWZvAOeRgcMtc7UI49l8oZNM cummtSiQEjqXpj61hbgNBBG3uFiUmnVdrYI4TzQuxqwcg71ZeFOVsp8NvX68SL47B2rb cQs6UJ9HED2gjXaL6iSIH7rfPRBsJOY9c8sa+MlvIB8piR3LC+RxN1Yw8Eq+X+xQpRcc aCOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=sxdNpbaxjlgrI7y1xjMXjF7UFp2IQQ7kDEnaAjSJx9g=; b=E5V/9Cw9Pf4AwtJcb3RcKDW0Ly1KcHVfcq3dylvewGjtQO0rqCqEo1/wTw1Btv1aCJ HlM5txq+1zFiOgXinz8JHWgQhfJsMHs77kb1GVrFvAIxVQpELE8yMj/wcZaMykr7VSQD 0D0bRAKRAGWeEnI8eF9a43h+6hyivjzs+HXWCjuCHs/E1LylijUWJ/giiFyH5sLWmEnr 4ywTE4rUEWaGPItXCxG7/hjLqNSX+3c/wBbIObWushfi5Yu8i4rs3tp7Kmo8NTkMHNnz yCzlZfAOP3F00kKtVwt7Pe+xrIX0VzWil0JEnYzfMas48PhwOmfsE/d0a7hMl130AO6x G/CQ== X-Gm-Message-State: AOAM532k9HL3RElgtTGjdLMG9kiFnDQ/LaKkzjrB20ivDrUUqXNACnHT Fo8bujjI07Og4t8DgqJOk6isZF7y2C4= X-Google-Smtp-Source: ABdhPJwH0fwOOUu+Q0WPK3ANFlUUkzoJcW31wN26ZavLe1t95+GxV7PDkRUbDf4XQVe/bhFngUx0qQ== X-Received: by 2002:a4a:d031:: with SMTP id w17mr5052846oor.33.1612798906284; Mon, 08 Feb 2021 07:41:46 -0800 (PST) Received: from Davids-MacBook-Pro.local ([8.48.134.33]) by smtp.googlemail.com with ESMTPSA id d17sm1097652ooh.32.2021.02.08.07.41.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Feb 2021 07:41:45 -0800 (PST) Subject: Re: [PATCH iproute2-next V3] devlink: add support for port params get/set To: Oleksandr Mazur , netdev@vger.kernel.org Cc: jiri@nvidia.com, davem@davemloft.net, linux-kernel@vger.kernel.org, kuba@kernel.org References: <20210202130445.5950-1-oleksandr.mazur@plvision.eu> From: David Ahern Message-ID: Date: Mon, 8 Feb 2021 08:41:43 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210202130445.5950-1-oleksandr.mazur@plvision.eu> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/2/21 6:04 AM, Oleksandr Mazur wrote: > Add implementation for the port parameters > getting/setting. > Add bash completion for port param. > Add man description for port param. > > Example: > $ devlink dev param set netdevsim/netdevsim0/0 name test_port_parameter value false cmode runtime > > $ devlink port param show netdevsim/netdevsim0/0 name test_port_parameter > netdevsim/netdevsim0/0: > name test_port_parameter type driver-specific > values: > cmode runtime value false > > $ devlink port -jp param show netdevsim/netdevsim0/0 name test_port_parameter > { > "param": { > "netdevsim/netdevsim0/0": [ { > "name": "test_port_parameter", > "type": "driver-specific", > "values": [ { > "cmode": "runtime", > "value": false > } ] > } ] > } > } > > Signed-off-by: Oleksandr Mazur > --- > V3: > 1) Add usage example; > 2) Remove stray newline in code; > V2: > 1) Add bash completion for port param; > 2) Add man decsription / examples for port param; > > bash-completion/devlink | 55 ++++++++ > devlink/devlink.c | 274 +++++++++++++++++++++++++++++++++++++++- > man/man8/devlink-port.8 | 65 ++++++++++ > 3 files changed, 388 insertions(+), 6 deletions(-) > does not apply to iproute2-next. please rebase