From: Florian Fainelli <f.fainelli@gmail.com>
To: Richard Cochran <richardcochran@gmail.com>, netdev@vger.kernel.org
Cc: David Miller <davem@davemloft.net>,
devicetree@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Jakub Kicinski <jakub.kicinski@netronome.com>,
Mark Rutland <mark.rutland@arm.com>,
Miroslav Lichvar <mlichvar@redhat.com>,
Murali Karicheri <m-karicheri2@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Willem de Bruijn <willemb@google.com>,
Wingman Kwok <w-kwok2@ti.com>
Subject: Re: [PATCH V7 net-next 01/11] net: phy: Introduce helper functions for time stamping support.
Date: Fri, 20 Dec 2019 14:24:48 -0800 [thread overview]
Message-ID: <c2c17e94-bf36-0816-260b-07fededd0e42@gmail.com> (raw)
In-Reply-To: <bb9bfc2826fa92bedde11664b0c0e0b9d028a689.1576865315.git.richardcochran@gmail.com>
On 12/20/19 10:15 AM, Richard Cochran wrote:
> Some parts of the networking stack and at least one driver test fields
> within the 'struct phy_device' in order to query time stamping
> capabilities and to invoke time stamping methods. This patch adds a
> functional interface around the time stamping fields. This will allow
> insulating the callers from future changes to the details of the time
> stamping implemenation.
>
> Signed-off-by: Richard Cochran <richardcochran@gmail.com>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Ideally we may even add locking annotations to make sure that there
there is no use after free in that the test is true, you de-reference
the PHY device and/or driver method, and boom. All callers appear to be
under RTNL right now.
--
Florian
next prev parent reply other threads:[~2019-12-20 22:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 18:15 [PATCH V7 net-next 00/11] Peer to Peer One-Step time stamping Richard Cochran
2019-12-20 18:15 ` [PATCH V7 net-next 01/11] net: phy: Introduce helper functions for time stamping support Richard Cochran
2019-12-20 22:24 ` Florian Fainelli [this message]
2019-12-20 18:15 ` [PATCH V7 net-next 02/11] net: macvlan: Use the PHY time stamping interface Richard Cochran
2019-12-20 22:26 ` Florian Fainelli
2019-12-20 18:15 ` [PATCH V7 net-next 03/11] net: vlan: " Richard Cochran
2019-12-20 22:26 ` Florian Fainelli
2019-12-20 18:15 ` [PATCH V7 net-next 04/11] net: ethtool: " Richard Cochran
2019-12-20 22:26 ` Florian Fainelli
2019-12-20 18:15 ` [PATCH V7 net-next 05/11] net: netcp_ethss: " Richard Cochran
2019-12-20 22:38 ` Florian Fainelli
2019-12-20 18:15 ` [PATCH V7 net-next 06/11] net: Introduce a new MII " Richard Cochran
2019-12-20 18:15 ` [PATCH V7 net-next 07/11] net: Add a layer for non-PHY MII time stamping drivers Richard Cochran
2019-12-21 10:32 ` Andrew Lunn
2019-12-20 18:15 ` [PATCH V7 net-next 08/11] dt-bindings: ptp: Introduce MII time stamping devices Richard Cochran
2019-12-20 18:15 ` [PATCH V7 net-next 09/11] net: mdio: of: Register discovered MII time stampers Richard Cochran
2019-12-20 22:41 ` Florian Fainelli
2019-12-20 18:15 ` [PATCH V7 net-next 10/11] net: Introduce peer to peer one step PTP time stamping Richard Cochran
2019-12-20 18:15 ` [PATCH V7 net-next 11/11] ptp: Add a driver for InES time stamping IP core Richard Cochran
2019-12-21 10:56 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2c17e94-bf36-0816-260b-07fededd0e42@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=jacob.e.keller@intel.com \
--cc=jakub.kicinski@netronome.com \
--cc=m-karicheri2@ti.com \
--cc=mark.rutland@arm.com \
--cc=mlichvar@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=w-kwok2@ti.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).