From: Florian Fainelli <f.fainelli@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>
Cc: DENG Qingfang <dqfext@gmail.com>,
Mauri Sandberg <sandberg@mailfence.com>
Subject: Re: [net-next PATCH 2/3 v1] net: dsa: rtl8366: Fix VLAN set-up
Date: Wed, 8 Jul 2020 19:18:48 -0700 [thread overview]
Message-ID: <c30321cf-6a7d-03bc-7fa3-9dbba0d84249@gmail.com> (raw)
In-Reply-To: <20200708204456.1365855-3-linus.walleij@linaro.org>
On 7/8/2020 1:44 PM, Linus Walleij wrote:
> Alter the rtl8366_vlan_add() to call rtl8366_set_vlan()
> inside the loop that goes over all VIDs since we now
> properly support calling that function more than once.
> Augment the loop to postincrement as this is more
> intuitive.
>
> The loop moved past the last VID but called
> rtl8366_set_vlan() with the port number instead of
> the VID, assuming a 1-to-1 correspondence between
> ports and VIDs. This was also a bug.
>
> Cc: DENG Qingfang <dqfext@gmail.com>
> Cc: Mauri Sandberg <sandberg@mailfence.com>
> Fixes: d8652956cf37 ("net: dsa: realtek-smi: Add Realtek SMI driver")
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2020-07-09 2:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 20:44 [net-bext PATCH 0/3 v1] Rectify RTL8366 default VLAN Behaviour Linus Walleij
2020-07-08 20:44 ` [net-next PATCH 1/3 v1] net: dsa: rtl8366: Fix VLAN semantics Linus Walleij
2020-07-09 2:13 ` Florian Fainelli
2020-07-08 20:44 ` [net-next PATCH 2/3 v1] net: dsa: rtl8366: Fix VLAN set-up Linus Walleij
2020-07-09 2:18 ` Florian Fainelli [this message]
2020-07-08 20:44 ` [net-next PATCH 3/3 v1] net: dsa: rtl8366: Use DSA core to set up VLAN Linus Walleij
2020-07-09 2:29 ` Florian Fainelli
2020-07-09 7:44 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c30321cf-6a7d-03bc-7fa3-9dbba0d84249@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=sandberg@mailfence.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).