From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,PDS_TONAME_EQ_TOLOCAL_SHORT,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A13D5C433FE for ; Wed, 9 Dec 2020 09:32:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5EE6323B7D for ; Wed, 9 Dec 2020 09:32:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729338AbgLIJcS (ORCPT ); Wed, 9 Dec 2020 04:32:18 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:50383 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727505AbgLIJcH (ORCPT ); Wed, 9 Dec 2020 04:32:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607506241; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eIdwFldhm6zBa8ine4tHp/RGdsb0WnWCdNxasu3YKbA=; b=g8G2Guyz3nAjaNUywmKuqYTQyBYt+RSuEFpQppcYFfVaOeoihiLplanBSn6XK3CiL9C2dN SnO6+5Ttoog71TrWC1u2M9+BApHDJGB1Wc9N++gYUpGm9kfRaSAPRuHqCUILgss/g71MXq 7NCvnwsakTq7KoCOnBv52GopxtDPF7k= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-381-2nC50HvXNnK0BgFAeTUY8w-1; Wed, 09 Dec 2020 04:30:37 -0500 X-MC-Unique: 2nC50HvXNnK0BgFAeTUY8w-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C430A107ACF5; Wed, 9 Dec 2020 09:30:34 +0000 (UTC) Received: from [10.72.12.31] (ovpn-12-31.pek2.redhat.com [10.72.12.31]) by smtp.corp.redhat.com (Postfix) with ESMTP id 45461100238C; Wed, 9 Dec 2020 09:30:25 +0000 (UTC) Subject: Re: [PATCH net-next] tun: fix ubuf refcount incorrectly on error path From: Jason Wang To: wangyunjian , "mst@redhat.com" Cc: "virtualization@lists.linux-foundation.org" , "netdev@vger.kernel.org" , "Lilijun (Jerry)" , xudingke References: <1606982459-41752-1-git-send-email-wangyunjian@huawei.com> <094f1828-9a73-033e-b1ca-43b73588d22b@redhat.com> <34EFBCA9F01B0748BEB6B629CE643AE60DB4E07B@dggemm513-mbx.china.huawei.com> <34EFBCA9F01B0748BEB6B629CE643AE60DB5CD27@DGGEMM533-MBX.china.huawei.com> Message-ID: Date: Wed, 9 Dec 2020 17:30:23 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2020/12/8 上午10:32, Jason Wang wrote: > > On 2020/12/7 下午9:38, wangyunjian wrote: >> I think the newly added code is easy to miss this problem, so I want to >> copy ubuf_info until we're sure there's no errors. >> >> Thanks, >> Yunjian > > > But isn't this actually a disabling of zerocopy? > > Thanks > > Sorry, I misread the patch. Please send a formal version, and let's move the discussion there. Thanks