From: Florian Fainelli <f.fainelli@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>, netdev@vger.kernel.org
Cc: phil@raspberrypi.org, jonathan@raspberrypi.org,
matthias.bgg@kernel.org, linux-rpi-kernel@lists.infradead.org,
wahrenst@gmx.net, nsaenzjulienne@suse.de,
Doug Berger <opendmb@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"open list:BROADCOM GENET ETHERNET DRIVER"
<bcm-kernel-feedback-list@broadcom.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] net: bcmgenet: Set phydev->dev_flags only for internal PHYs
Date: Fri, 11 Oct 2019 12:57:33 -0700 [thread overview]
Message-ID: <c3e47479-1f13-f35c-5153-a9974723ac5a@gmail.com> (raw)
In-Reply-To: <20191011195349.9661-1-f.fainelli@gmail.com>
On 10/11/19 12:53 PM, Florian Fainelli wrote:
> phydev->dev_flags is entirely dependent on the PHY device driver which
> is going to be used, setting the internal GENET PHY revision in those
> bits only makes sense when drivers/net/phy/bcm7xxx.c is the PHY driver
> being used.
>
> Fixes: 487320c54143 ("net: bcmgenet: communicate integrated PHY revision to PHY driver")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
FWIW, I am preparing net-next material which allows the phy_flags to be
scoped towards a specific PHY driver, and not broadly applied, but until
this happens, we should probably go with this change.
> ---
> drivers/net/ethernet/broadcom/genet/bcmmii.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c
> index 970e478a9017..94d1dd5d56bf 100644
> --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c
> +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c
> @@ -273,11 +273,12 @@ int bcmgenet_mii_probe(struct net_device *dev)
> struct bcmgenet_priv *priv = netdev_priv(dev);
> struct device_node *dn = priv->pdev->dev.of_node;
> struct phy_device *phydev;
> - u32 phy_flags;
> + u32 phy_flags = 0;
> int ret;
>
> /* Communicate the integrated PHY revision */
> - phy_flags = priv->gphy_rev;
> + if (priv->internal_phy)
> + phy_flags = priv->gphy_rev;
>
> /* Initialize link state variables that bcmgenet_mii_setup() uses */
> priv->old_link = -1;
>
--
Florian
next prev parent reply other threads:[~2019-10-11 19:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 19:53 [PATCH net] net: bcmgenet: Set phydev->dev_flags only for internal PHYs Florian Fainelli
2019-10-11 19:57 ` Florian Fainelli [this message]
2019-10-15 0:49 ` Doug Berger
2019-10-15 17:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3e47479-1f13-f35c-5153-a9974723ac5a@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=jonathan@raspberrypi.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=matthias.bgg@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nsaenzjulienne@suse.de \
--cc=opendmb@gmail.com \
--cc=phil@raspberrypi.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).