From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B54C6ABC for ; Mon, 5 Jun 2023 13:04:55 +0000 (UTC) Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3FC1FD; Mon, 5 Jun 2023 06:04:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1685970294; x=1717506294; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=nROIitPltbPWMd0kgRZLjZjy+4djGlBLlehlPkk3LwQ=; b=MFCFjrbeaazSaqcICVkfwCQTeStGd/SZ3BBeJ4eJcamyZHt7zZsusDce vdOhBAkenqNmZOMdhkwtCNYMt3nsZW8jbp7xQjcN1371fCpA3nvekYfO9 VEY1R+xzK4oXUi7uMz5NlEiN9Jp+p/zeexMNohmDefyZ4Fof8BUwvL5Lk 5oKREt5bmixHeePJDMpRWXcBoNvLN1eFROJLf0ZQmEGkHzg0xH+2cuFhQ G1fhozPQSwA0vOTEM+aSLwERh7/MRlgIrXLGUBAU0+w1OqNt58cpZquBH mDUjjHic4UHl78kVvboZzovUdykwg9Rl4ONYq/Sxb0zKYkIE1kFRN0ucz w==; X-IronPort-AV: E=Sophos;i="6.00,217,1681196400"; d="scan'208";a="214657607" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 05 Jun 2023 06:04:52 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 5 Jun 2023 06:04:47 -0700 Received: from [10.159.245.112] (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2507.21 via Frontend Transport; Mon, 5 Jun 2023 06:04:41 -0700 Message-ID: Date: Mon, 5 Jun 2023 15:04:34 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 17/21] power: reset: at91-poweroff: lookup for proper pmc dt node for sam9x7 Content-Language: en-US To: Krzysztof Kozlowski , Varshini Rajendran , , , , , , , , , , , , , , , , , , , , , , , , , , , , , CC: , , , , , , References: <20230603200243.243878-1-varshini.rajendran@microchip.com> <20230603200243.243878-18-varshini.rajendran@microchip.com> <2a538004-351f-487a-361c-df723d186c27@linaro.org> From: Nicolas Ferre Organization: microchip In-Reply-To: <2a538004-351f-487a-361c-df723d186c27@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On 05/06/2023 at 08:43, Krzysztof Kozlowski wrote: > On 03/06/2023 22:02, Varshini Rajendran wrote: >> Use sam9x7 pmc's compatible to lookup for in the SHDWC driver >> >> Signed-off-by: Varshini Rajendran >> --- >> drivers/power/reset/at91-sama5d2_shdwc.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/power/reset/at91-sama5d2_shdwc.c b/drivers/power/reset/at91-sama5d2_shdwc.c >> index d8ecffe72f16..d0f29b99f25e 100644 >> --- a/drivers/power/reset/at91-sama5d2_shdwc.c >> +++ b/drivers/power/reset/at91-sama5d2_shdwc.c >> @@ -326,6 +326,7 @@ static const struct of_device_id at91_pmc_ids[] = { >> { .compatible = "atmel,sama5d2-pmc" }, >> { .compatible = "microchip,sam9x60-pmc" }, >> { .compatible = "microchip,sama7g5-pmc" }, >> + { .compatible = "microchip,sam9x7-pmc" }, > > Why do you need new entry if these are compatible? Yes, PMC is very specific to a SoC silicon. As we must look for it in the shutdown controller, I think we need a new entry here. Best regards, Nicolas -- Nicolas Ferre