From: Alexandre Torgue <alexandre.torgue@st.com>
To: Christophe Roullier <christophe.roullier@st.com>,
<robh@kernel.org>, <davem@davemloft.net>, <joabreu@synopsys.com>,
<mark.rutland@arm.com>, <mcoquelin.stm32@gmail.com>,
<peppe.cavallaro@st.com>
Cc: <linux-stm32@st-md-mailman.stormreply.com>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <netdev@vger.kernel.org>,
<andrew@lunn.ch>
Subject: Re: [PATCH 1/1] ARM: dts: stm32: replace rgmii mode with rgmii-id on stm32mp15 boards
Date: Mon, 17 Jun 2019 14:34:49 +0200 [thread overview]
Message-ID: <c53808dd-f1d2-2865-7d45-fa2ca875b95a@st.com> (raw)
In-Reply-To: <20190617085018.20352-2-christophe.roullier@st.com>
Hi Christophe
On 6/17/19 10:50 AM, Christophe Roullier wrote:
> On disco and eval board, Tx and Rx delay are applied (pull-up of 4.7k
> put on VDD) so which correspond to RGMII-ID mode with internal RX and TX
> delays provided by the PHY, the MAC should not add the RX or TX delays
> in this case
>
> Signed-off-by: Christophe Roullier <christophe.roullier@st.com>
> ---
> arch/arm/boot/dts/stm32mp157a-dk1.dts | 2 +-
> arch/arm/boot/dts/stm32mp157c-ev1.dts | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/stm32mp157a-dk1.dts b/arch/arm/boot/dts/stm32mp157a-dk1.dts
> index 098dbfb06b61..2c105740dfad 100644
> --- a/arch/arm/boot/dts/stm32mp157a-dk1.dts
> +++ b/arch/arm/boot/dts/stm32mp157a-dk1.dts
> @@ -51,7 +51,7 @@
> pinctrl-0 = <ðernet0_rgmii_pins_a>;
> pinctrl-1 = <ðernet0_rgmii_pins_sleep_a>;
> pinctrl-names = "default", "sleep";
> - phy-mode = "rgmii";
> + phy-mode = "rgmii-id";
> max-speed = <1000>;
> phy-handle = <&phy0>;
>
> diff --git a/arch/arm/boot/dts/stm32mp157c-ev1.dts b/arch/arm/boot/dts/stm32mp157c-ev1.dts
> index b6aca40b9b90..ab1393caf799 100644
> --- a/arch/arm/boot/dts/stm32mp157c-ev1.dts
> +++ b/arch/arm/boot/dts/stm32mp157c-ev1.dts
> @@ -79,7 +79,7 @@
> pinctrl-0 = <ðernet0_rgmii_pins_a>;
> pinctrl-1 = <ðernet0_rgmii_pins_sleep_a>;
> pinctrl-names = "default", "sleep";
> - phy-mode = "rgmii";
> + phy-mode = "rgmii-id";
> max-speed = <1000>;
> phy-handle = <&phy0>;
>
>
Applied on stm32-next.
Thanks.
Alex
prev parent reply other threads:[~2019-06-17 12:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 8:50 [PATCH 0/1] ARM: dts: stm32: replace rgmii mode with rgmii-id on stm32mp15 boards Christophe Roullier
2019-06-17 8:50 ` [PATCH 1/1] " Christophe Roullier
2019-06-17 12:34 ` Alexandre Torgue [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c53808dd-f1d2-2865-7d45-fa2ca875b95a@st.com \
--to=alexandre.torgue@st.com \
--cc=andrew@lunn.ch \
--cc=christophe.roullier@st.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=joabreu@synopsys.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).