From: David Ahern <dsahern@gmail.com>
To: Daniel Borkmann <daniel@iogearbox.net>, ast@kernel.org
Cc: john.fastabend@gmail.com, netdev@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next 1/6] bpf: improve bpf_redirect_neigh helper description
Date: Thu, 8 Oct 2020 15:00:13 -0700 [thread overview]
Message-ID: <c57b1ea5-019e-af07-2307-6837ba7233aa@gmail.com> (raw)
In-Reply-To: <20201008213148.26848-2-daniel@iogearbox.net>
On 10/8/20 2:31 PM, Daniel Borkmann wrote:
> Follow-up to address David's feedback that we should better describe internals
> of the bpf_redirect_neigh() helper.
>
> Suggested-by: David Ahern <dsahern@gmail.com>
> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
> ---
> include/uapi/linux/bpf.h | 10 +++++++---
> tools/include/uapi/linux/bpf.h | 10 +++++++---
> 2 files changed, 14 insertions(+), 6 deletions(-)
>
Looks good to me. Thanks,
Reviewed-by: David Ahern <dsahern@gmail.com>
next prev parent reply other threads:[~2020-10-08 22:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 21:31 [PATCH bpf-next 0/6] Follow-up BPF helper improvements Daniel Borkmann
2020-10-08 21:31 ` [PATCH bpf-next 1/6] bpf: improve bpf_redirect_neigh helper description Daniel Borkmann
2020-10-08 22:00 ` David Ahern [this message]
2020-10-08 21:31 ` [PATCH bpf-next 2/6] bpf: add redirect_peer helper Daniel Borkmann
2020-10-08 21:31 ` [PATCH bpf-next 3/6] bpf: allow for map-in-map with dynamic inner array map entries Daniel Borkmann
2020-10-09 3:19 ` Yonghong Song
2020-10-08 21:31 ` [PATCH bpf-next 4/6] bpf, selftests: add test for different array inner map size Daniel Borkmann
2020-10-09 3:44 ` Yonghong Song
2020-10-08 21:31 ` [PATCH bpf-next 5/6] bpf, selftests: make redirect_neigh test more extensible Daniel Borkmann
2020-10-09 3:58 ` Yonghong Song
2020-10-08 21:31 ` [PATCH bpf-next 6/6] bpf, selftests: add redirect_peer selftest Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c57b1ea5-019e-af07-2307-6837ba7233aa@gmail.com \
--to=dsahern@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).