From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43523C433ED for ; Thu, 8 Apr 2021 13:43:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0970161107 for ; Thu, 8 Apr 2021 13:43:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231726AbhDHNnl (ORCPT ); Thu, 8 Apr 2021 09:43:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230467AbhDHNnk (ORCPT ); Thu, 8 Apr 2021 09:43:40 -0400 Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07394C061760 for ; Thu, 8 Apr 2021 06:43:28 -0700 (PDT) Received: by mail-qk1-x735.google.com with SMTP id q26so2161857qkm.6 for ; Thu, 08 Apr 2021 06:43:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mojatatu-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4Yjf1Zg11Qg54blA/eFQI8A3y3BgYDcMxe6bbo03brc=; b=SvsCllA3+Bxyp4Jk/uGBfq9xEg7BN04oCF8G6KNLqccoUi5aDkLAhDjji+QdT6xguu sEXnrF8EBtqogEQlA8fUa+Ek/zDj6M0nvnsDhPHdz5e0rr2horGWrsNFzG7PcxE9cgSK Q/ux1oSqZBLuv3mbF6qgjXqdkKg9jMa5gVWSqcXN4S6rMF/tviHrfL+Er73gl/eG+7yF vWGuBXzoY/5VWjDepfnRDTsAqTOgJ4kAj8byIDH3iOs9B+Q19iMeROc//aGa8iKz0DBw jI9Gyx+j3Cty/9rJkE/FfnpaNnIU/xiGTlrafpru9OnM1JH6IMHfeG40APmflQXafiXN agRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4Yjf1Zg11Qg54blA/eFQI8A3y3BgYDcMxe6bbo03brc=; b=K7le24eEnCkY2rw80/DaqTbbSg+vYCU12qMvnbhWglTfr/zfQcTzqR88oVlVBjpez9 Kt+zjcC5v7d3ZT8bKTOp5BqzXNp2ppQs6XFnDLijH6tX9pIi95UtVvw5NKWH4oAWQJd+ DHO5V2Z0JSTV0ooNHrwIDmV4CfQPsjBFPJUWEDBqEGbegmGSJ3/ktc65oTOJ+HS+Plr2 LKwJFqzqHi1Ph09M5de1Slbw150yCFKQukQlWnmo94IRTbivSuydjI8Gei1nIHN8sM5B 4Yc247LuuMeeznoYqIx80+cd+wpPCkgxhp3l9g8uhOmZvbIdd/j1pbEdsuDIph4Nl8Zv OyWg== X-Gm-Message-State: AOAM532c4sTayfq3p+ODBO8j1aKV3YVbNgUXAKQ/mrqcKVca6DSIjsVm zIsgJyvg4F0AHud2aRHKWTYE9A== X-Google-Smtp-Source: ABdhPJz1tUntW5Rlvw+YCXZAgFh8XNpzVdjjYfOfl5nbnEcMPoCasIT1s7ENqOls2k6EPvhs02Jeww== X-Received: by 2002:a05:620a:22b5:: with SMTP id p21mr8811999qkh.196.1617889407347; Thu, 08 Apr 2021 06:43:27 -0700 (PDT) Received: from [192.168.1.79] (bras-base-kntaon1617w-grc-22-184-144-36-31.dsl.bell.ca. [184.144.36.31]) by smtp.googlemail.com with ESMTPSA id m25sm18821050qtq.59.2021.04.08.06.43.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Apr 2021 06:43:26 -0700 (PDT) Subject: Re: [PATCH net v2 2/3] net: sched: fix action overwrite reference counting To: Vlad Buslov , Cong Wang Cc: Linux Kernel Network Developers , Kumar Kartikeya Dwivedi , David Miller , Jiri Pirko , Jakub Kicinski , =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgense?= =?UTF-8?Q?n?= , Marcelo Ricardo Leitner , Davide Caratti References: <20210407153604.1680079-1-vladbu@nvidia.com> <20210407153604.1680079-3-vladbu@nvidia.com> From: Jamal Hadi Salim Message-ID: Date: Thu, 8 Apr 2021 09:43:25 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2021-04-08 3:50 a.m., Vlad Buslov wrote: > > On Thu 08 Apr 2021 at 02:50, Cong Wang wrote: > Origins of setting ovr based on NLM_F_REPLACE are lost since this code > goes back to Linus' Linux-2.6.12-rc2 commit. Jamal, do you know if this > is the expected behavior or just something unintended? Seems our emails crossed path. The problem with ovr is the ambiguity of whether we are saying both CREATE and REPLACE or just one or the other. We could improve the kernel side by just passing the flags to each action. Note it is too late to fix iproute2 without some backward compat flag; but it may not be too late for someone writting a new application in user space. cheers, jamal