From: Heiner Kallweit <hkallweit1@gmail.com>
To: Dejin Zheng <zhengdejin5@gmail.com>,
andrew@lunn.ch, f.fainelli@gmail.com, linux@armlinux.org.uk,
davem@davemloft.net, tglx@linutronix.de, broonie@kernel.org,
corbet@lwn.net, mchehab+samsung@kernel.org,
netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 3/7] net: phy: introduce phy_read_mmd_poll_timeout macro
Date: Thu, 19 Mar 2020 17:56:39 +0100 [thread overview]
Message-ID: <c88c0ce1-af42-db67-22bc-92e82bd9efbf@gmail.com> (raw)
In-Reply-To: <20200319163910.14733-4-zhengdejin5@gmail.com>
On 19.03.2020 17:39, Dejin Zheng wrote:
> it is sometimes necessary to poll a phy register by phy_read_mmd()
> function until its value satisfies some condition. introduce
> phy_read_mmd_poll_timeout() macros that do this.
>
> Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
> ---
> include/linux/phy.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index 36d9dea04016..a30e9008647f 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -24,6 +24,7 @@
> #include <linux/mod_devicetable.h>
> #include <linux/u64_stats_sync.h>
> #include <linux/irqreturn.h>
> +#include <linux/iopoll.h>
>
> #include <linux/atomic.h>
>
> @@ -784,6 +785,9 @@ static inline int __phy_modify_changed(struct phy_device *phydev, u32 regnum,
> */
> int phy_read_mmd(struct phy_device *phydev, int devad, u32 regnum);
>
> +#define phy_read_mmd_poll_timeout(val, cond, sleep_us, timeout_us, args...) \
> + read_poll_timeout(phy_read_mmd, val, cond, sleep_us, timeout_us, args)
> +
> /**
> * __phy_read_mmd - Convenience function for reading a register
> * from an MMD on a given PHY.
>
I'm not fully convinced. Usage of the new macro with its lots of
parameters makes the code quite hard to read. Therefore I'm also
not a big fan of readx_poll_timeout.
Even though I didn't invent it, I prefer the way DECLARE_RTL_COND
is used in the r8169 driver. The resulting code is much better
to read, and in case of a timeout a helpful warning is printed
automatically.
next prev parent reply other threads:[~2020-03-19 16:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 16:39 [PATCH net-next 0/7] introduce read_poll_timeout Dejin Zheng
2020-03-19 16:39 ` [PATCH net-next 1/7] iopoll: introduce read_poll_timeout macro Dejin Zheng
2020-03-19 16:39 ` [PATCH net-next 2/7] iopoll: redefined readx_poll_timeout macro to simplify the code Dejin Zheng
2020-03-19 16:39 ` [PATCH net-next 3/7] net: phy: introduce phy_read_mmd_poll_timeout macro Dejin Zheng
2020-03-19 16:56 ` Heiner Kallweit [this message]
2020-03-19 17:10 ` Andrew Lunn
2020-03-19 16:39 ` [PATCH net-next 4/7] net: phy: bcm84881: use phy_read_mmd_poll_timeout() to simplify the code Dejin Zheng
2020-03-19 17:23 ` Andrew Lunn
2020-03-19 16:39 ` [PATCH net-next 5/7] net: phy: aquantia: " Dejin Zheng
2020-03-19 16:39 ` [PATCH net-next 6/7] net: phy: introduce phy_read_poll_timeout macro Dejin Zheng
2020-03-19 16:39 ` [PATCH net-next 7/7] net: phy: use phy_read_poll_timeout() to simplify the code Dejin Zheng
2020-03-19 16:42 ` [PATCH net-next 0/7] introduce read_poll_timeout Florian Fainelli
2020-03-20 11:34 ` Dejin Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c88c0ce1-af42-db67-22bc-92e82bd9efbf@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mchehab+samsung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=zhengdejin5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).