From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51736C433ED for ; Thu, 8 Apr 2021 14:20:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2061E610A3 for ; Thu, 8 Apr 2021 14:20:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231830AbhDHOVG (ORCPT ); Thu, 8 Apr 2021 10:21:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231672AbhDHOVF (ORCPT ); Thu, 8 Apr 2021 10:21:05 -0400 Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [IPv6:2607:f8b0:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2359C061760 for ; Thu, 8 Apr 2021 07:20:54 -0700 (PDT) Received: by mail-ot1-x336.google.com with SMTP id d3-20020a9d29030000b029027e8019067fso517580otb.13 for ; Thu, 08 Apr 2021 07:20:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=wU2+tpWIloggFrxL5x8nb728jOdIxEZhw5INUq9tXc8=; b=rdBj1q5zYA1XeUOkGfyGa+Cq3l9nNzOOK+6f1oIrl3u9K4RtMyp9S1BUOD4hah9RrO Q9C0zmyGTS+IUCW39YL1lawTC4+g8R4DhlhYOTAUul6DxUnCJMji9aoCEQUwXbTiiTCK IFlbzguVcvxeCMATdEgwKm9C7wfAW3aituigY6gBg2MS3t5r7E/IhXphCgDjkJSH26wx oWG3myYbYy5E+fqq0bvSOT5trNBcqu4ctIvdSjkcCCzr4PZ3qLnO/snEoRMDs6WkRa4L 8EkwSSsaGfGYSNcoqvWV1Fyv9YN35oThWuSict68aP97idI7dYChAXvAgzh6mGiMpdyo nqYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wU2+tpWIloggFrxL5x8nb728jOdIxEZhw5INUq9tXc8=; b=eXWEUJf1t7/Xre0NSn3affvTaYgDg1QDnvLLy3SQlgsusAaCgLd6nQ21DqvNa9qqpG TULTE1NzCFazdoGaoUU24DBRdF9lKPiQWjmb7Uin25Gc6T4uyAS8Un48F1WUtpq2YhMI Iz3UOLnlOfirlsxMGV9yq2ePynWx/AyNZWAshIrNxvzcclrEMrVwO9Pnk87vCHYB5J4K W1radjRuwEZBfJMda3ghhsxugFUe1OUGXeCa3QWWM8+OmWwZh9qwgHBWYWuINadEaT0b X3Ulu6jKouTY0sxlasea9Szbyf5mwHgofmO/Ie+CRby4i1rEYX9lo37WFjb4Y5y/heUr Ws3w== X-Gm-Message-State: AOAM530aixIUj/dkUEg755I3RxHDS077h26Jq+KdmVsbK0hQRNIZ7vay XSVq5GdDRgM457MaiCLOTGWYVIGzibw= X-Google-Smtp-Source: ABdhPJzPF+hxTH+lE+QKuS2ava+W8JVdbgyywZm6OXRH4mEaDrdUZKiC5aORFliejhdP/bNISmF5Rg== X-Received: by 2002:a9d:5f15:: with SMTP id f21mr7911081oti.226.1617891654266; Thu, 08 Apr 2021 07:20:54 -0700 (PDT) Received: from Davids-MacBook-Pro.local ([8.48.134.56]) by smtp.googlemail.com with ESMTPSA id q67sm4994232oic.55.2021.04.08.07.20.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Apr 2021 07:20:54 -0700 (PDT) Subject: Re: [PATCH v2] ipv6: report errors for iftoken via netlink extack To: Stephen Hemminger , netdev@vger.kernel.org Cc: Hongren Zheng References: <20210407155912.19602-1-sthemmin@microsoft.com> From: David Ahern Message-ID: Date: Thu, 8 Apr 2021 08:20:50 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210407155912.19602-1-sthemmin@microsoft.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/7/21 9:59 AM, Stephen Hemminger wrote: > From: Stephen Hemminger > > Setting iftoken can fail for several different reasons but there > and there was no report to user as to the cause. Add netlink > extended errors to the processing of the request. > > This requires adding additional argument through rtnl_af_ops > set_link_af callback. > > Reported-by: Hongren Zheng > Signed-off-by: Stephen Hemminger > --- > v2 - fix typo that broke build > > include/net/rtnetlink.h | 4 ++-- > net/core/rtnetlink.c | 2 +- > net/ipv4/devinet.c | 3 ++- > net/ipv6/addrconf.c | 32 ++++++++++++++++++++++++++------ > 4 files changed, 31 insertions(+), 10 deletions(-) > Reviewed-by: David Ahern