From: Tobias Langer <langer@cs.fau.de>
To: Dorothea Ehrl <dorothea.ehrl@fau.de>,
manishc@marvell.com, GR-Linux-NIC-Dev@marvell.com,
gregkh@linuxfoundation.org, netdev@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Cc: Vanessa Hack <vanessa.hack@fau.de>, linux-kernel@i4.cs.fau.de
Subject: Re: [i4passt] [PATCH 1/5] staging/qlge: remove initialising of static local variable
Date: Fri, 29 Nov 2019 08:17:52 +0100 [thread overview]
Message-ID: <cac212e9-2412-7919-223c-0193df74ba2a@cs.fau.de> (raw)
In-Reply-To: <20191127123052.16424-1-dorothea.ehrl@fau.de>
[-- Attachment #1: Type: text/plain, Size: 1036 bytes --]
Hi,
the patch series looks fine to me, I think you can go ahead and send it
to the kernel.
Kind regards
Tobias
On 27.11.19 13:30, Dorothea Ehrl wrote:
> This patch fixes "ERROR: do not initialise statics to 0" by checkpatch.pl.
>
> Signed-off-by: Dorothea Ehrl <dorothea.ehrl@fau.de>
> Co-developed-by: Vanessa Hack <vanessa.hack@fau.de>
> Signed-off-by: Vanessa Hack <vanessa.hack@fau.de>
> ---
> drivers/staging/qlge/qlge_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
> index 6ad4515311f7..587102aa7fbf 100644
> --- a/drivers/staging/qlge/qlge_main.c
> +++ b/drivers/staging/qlge/qlge_main.c
> @@ -4578,7 +4578,7 @@ static int qlge_probe(struct pci_dev *pdev,
> {
> struct net_device *ndev = NULL;
> struct ql_adapter *qdev = NULL;
> - static int cards_found = 0;
> + static int cards_found;
> int err = 0;
>
> ndev = alloc_etherdev_mq(sizeof(struct ql_adapter),
> --
> 2.20.1
>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5942 bytes --]
prev parent reply other threads:[~2019-11-29 7:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 12:30 [PATCH 1/5] staging/qlge: remove initialising of static local variable Dorothea Ehrl
2019-11-27 12:30 ` [PATCH 2/5] staging/qlge: add blank lines after declarations Dorothea Ehrl
2019-11-27 12:30 ` [PATCH 3/5] staging/qlge: add braces to conditional statement Dorothea Ehrl
2019-11-27 12:30 ` [PATCH 4/5] staging/qlge: remove braces in " Dorothea Ehrl
2019-11-27 12:30 ` [PATCH 5/5] staging/qlge: fix block comment coding style Dorothea Ehrl
2019-11-29 7:17 ` Tobias Langer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cac212e9-2412-7919-223c-0193df74ba2a@cs.fau.de \
--to=langer@cs.fau.de \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=devel@driverdev.osuosl.org \
--cc=dorothea.ehrl@fau.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=vanessa.hack@fau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).