From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2B50C3A5A1 for ; Wed, 28 Aug 2019 04:19:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B505B21883 for ; Wed, 28 Aug 2019 04:19:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DxUS8ZMc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725862AbfH1ETh (ORCPT ); Wed, 28 Aug 2019 00:19:37 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:42601 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725601AbfH1ETg (ORCPT ); Wed, 28 Aug 2019 00:19:36 -0400 Received: by mail-pg1-f195.google.com with SMTP id p3so665495pgb.9 for ; Tue, 27 Aug 2019 21:19:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=/I/Thq/zbCuqhNtW0mJ3x2CAl+PXjC3U/HhaAbrm7qw=; b=DxUS8ZMch6eeigJ9Tbh/m6RKrNb/qdbOI9bhI//WeHL7nP9pC0cVTBXow3VoU2ls+p Znk14wWf5B9eIKA/xJcCztHGlEL8fQQsxpspnwmpfPhKau3zAmjlomp/BP8cq0pZLqlT Y2dRrwgX/4YSfP6bPqo+HiqEI7OLOVxil5PYWC+U7YzzvDQa6dX62oiHaFHg4duz2XpU 8JS9Z3/hT3jigTK/ZKybznGN8R2etnIHQVXIJAbDS5oWGGizcu//VMiZ4mSrbhQ73gMd fzjcr4NepmOnaDg8e+lnbOi9HvaWOfJ9PuSPJITm/9MgBTHMrNyrzpyyXisN8OUDU7SA j1JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=/I/Thq/zbCuqhNtW0mJ3x2CAl+PXjC3U/HhaAbrm7qw=; b=eYAT2X2WWupOhQDK/0vGFGuP70FS82b9OXMtpcyqLtMvxbUXb54t097C+GYGi7fhzg LAL3it/1+1Z/7TZeVuBVEDUDlxU79ncL/8cScKaYPY4auqqi7m4qYe1FfcLcUSmVkgWR oJrjB5RDaK3DkqazEIOnvutth0bETCDAqLkGHYTjejV+b6o1ZChBo+wjA0PCjphzm3bT aYUi7GbK1KFTb2hpuqfDF9WY+gbyHL2cWXCo97vFX1l0vbz9m7jakp52H9GK4hP2snIJ LR8Ky8EOsfLoPFVic7JIxGZpFKzvAAl/yYE5RnsyuOSHqUFJalRnWnwAJ0k2sQVSF9IX ET1g== X-Gm-Message-State: APjAAAVLKH2+VWw2W9RBxpDHrUtVz3FAGyQ8VY/PqxdqsjG88vJJm1hM G5UF5//e6j9y/4NldpMZIOY= X-Google-Smtp-Source: APXvYqy3vSI9/nPQIxys3ZkxTRydhF9jCsVBKJo6+VlF8EgRmbNLdYPG0iPtcPUiQOBVTKcB1FkXTA== X-Received: by 2002:a65:5188:: with SMTP id h8mr1716512pgq.294.1566965975864; Tue, 27 Aug 2019 21:19:35 -0700 (PDT) Received: from [192.168.0.16] (97-115-90-227.ptld.qwest.net. [97.115.90.227]) by smtp.gmail.com with ESMTPSA id n10sm825420pgv.67.2019.08.27.21.19.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Aug 2019 21:19:35 -0700 (PDT) Subject: Re: [PATCH V3 net 1/2] openvswitch: Properly set L4 keys on "later" IP fragments To: Pravin Shelar Cc: Linux Kernel Network Developers , Joe Stringer References: <1566917890-22304-1-git-send-email-gvrose8192@gmail.com> From: Gregory Rose Message-ID: Date: Tue, 27 Aug 2019 21:19:33 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 8/27/2019 5:33 PM, Pravin Shelar wrote: > On Tue, Aug 27, 2019 at 7:58 AM Greg Rose wrote: >> When IP fragments are reassembled before being sent to conntrack, the >> key from the last fragment is used. Unless there are reordering >> issues, the last fragment received will not contain the L4 ports, so the >> key for the reassembled datagram won't contain them. This patch updates >> the key once we have a reassembled datagram. >> >> The handle_fragments() function works on L3 headers so we pull the L3/L4 >> flow key update code from key_extract into a new function >> 'key_extract_l3l4'. Then we add a another new function >> ovs_flow_key_update_l3l4() and export it so that it is accessible by >> handle_fragments() for conntrack packet reassembly. >> >> Co-authored by: Justin Pettit >> Signed-off-by: Greg Rose >> > Looks good to me. > > Acked-by: Pravin B Shelar > > Thanks, > Pravin. Thanks Pravin. I missed a dash in the Co-authored-by line.  If that could be fixed up on commit then good, otherwise I can resend. - Greg