From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mauricio Vasquez Subject: Re: [RFC PATCH bpf-next v3 1/7] bpf: rename stack trace map Date: Tue, 18 Sep 2018 21:53:15 -0500 Message-ID: References: <153724634652.7866.6354309647800281793.stgit@kernel> <153724635419.7866.6301500459081173494.stgit@kernel> <20180918230551.7rh3wytacry7i3wl@ast-mbp> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Alexei Starovoitov , Daniel Borkmann , netdev@vger.kernel.org, Yonghong Song To: Alexei Starovoitov Return-path: Received: from fm1nodo1.polito.it ([130.192.180.16]:34793 "EHLO antispam.polito.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725877AbeISI32 (ORCPT ); Wed, 19 Sep 2018 04:29:28 -0400 In-Reply-To: <20180918230551.7rh3wytacry7i3wl@ast-mbp> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 09/18/2018 06:05 PM, Alexei Starovoitov wrote: > On Tue, Sep 18, 2018 at 06:52:34AM +0200, Mauricio Vasquez B wrote: >> In the following patches queue and stack maps (FIFO and LIFO >> datastructures) will be implemented. In order to avoid confusion and >> a possible name clash rename stackmap.c to stacktracemap.c and >> stack_map_ops to stack_trace_map_ops >> >> Signed-off-by: Mauricio Vasquez B >> --- >> include/linux/bpf_types.h | 2 >> kernel/bpf/Makefile | 2 >> kernel/bpf/stackmap.c | 624 -------------------------------------------- >> kernel/bpf/stacktracemap.c | 624 ++++++++++++++++++++++++++++++++++++++++++++ >> 4 files changed, 626 insertions(+), 626 deletions(-) >> delete mode 100644 kernel/bpf/stackmap.c >> create mode 100644 kernel/bpf/stacktracemap.c > Just new file for stack/queue will be enough. I understand that unfortunate name confusion, > but this is too late. It will cause all sorts of headaches in fixes that go to net/stable. > > Ok, will only rename stack_map_ops to stack_trace_map_ops then.