From: Paolo Abeni <pabeni@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: netdev <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Coco Li <lixiaoyan@google.com>
Subject: Re: [PATCH net-next 08/15] ipv6: Add hop-by-hop header to jumbograms in ip6_output
Date: Thu, 03 Feb 2022 10:07:32 +0100 [thread overview]
Message-ID: <cefef8b5dfd8f5944e74f5f6bf09692f4984db6a.camel@redhat.com> (raw)
In-Reply-To: <20220203015140.3022854-9-eric.dumazet@gmail.com>
On Wed, 2022-02-02 at 17:51 -0800, Eric Dumazet wrote:
> From: Coco Li <lixiaoyan@google.com>
>
> Instead of simply forcing a 0 payload_len in IPv6 header,
> implement RFC 2675 and insert a custom extension header.
>
> Note that only TCP stack is currently potentially generating
> jumbograms, and that this extension header is purely local,
> it wont be sent on a physical link.
>
> This is needed so that packet capture (tcpdump and friends)
> can properly dissect these large packets.
>
> Signed-off-by: Coco Li <lixiaoyan@google.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> ---
> include/linux/ipv6.h | 1 +
> net/ipv6/ip6_output.c | 22 ++++++++++++++++++++--
> 2 files changed, 21 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/ipv6.h b/include/linux/ipv6.h
> index 1e0f8a31f3de175659dca9ecee9f97d8b01e2b68..d3fb87e1589997570cde9cb5d92b2222008a229d 100644
> --- a/include/linux/ipv6.h
> +++ b/include/linux/ipv6.h
> @@ -144,6 +144,7 @@ struct inet6_skb_parm {
> #define IP6SKB_L3SLAVE 64
> #define IP6SKB_JUMBOGRAM 128
> #define IP6SKB_SEG6 256
> +#define IP6SKB_FAKEJUMBO 512
> };
>
> #if defined(CONFIG_NET_L3_MASTER_DEV)
> diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c
> index 0c6c971ce0a58b50f8a9349b8507dffac9c7818c..f78ba145620560e5d7cb25aaf16fec61ddd9ed40 100644
> --- a/net/ipv6/ip6_output.c
> +++ b/net/ipv6/ip6_output.c
> @@ -180,7 +180,9 @@ static int __ip6_finish_output(struct net *net, struct sock *sk, struct sk_buff
> #endif
>
> mtu = ip6_skb_dst_mtu(skb);
> - if (skb_is_gso(skb) && !skb_gso_validate_network_len(skb, mtu))
> + if (skb_is_gso(skb) &&
> + !(IP6CB(skb)->flags & IP6SKB_FAKEJUMBO) &&
> + !skb_gso_validate_network_len(skb, mtu))
> return ip6_finish_output_gso_slowpath_drop(net, sk, skb, mtu);
If I read correctly jumbogram with gso len not fitting the egress
device MTU will not be fragmented, as opposed to plain old GSO packets.
Am I correct? why fragmentation is not needed for jumbogram?
Thanks!
Paolo
next prev parent reply other threads:[~2022-02-03 9:07 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 1:51 [PATCH net-next 00/15] tcp: BIG TCP implementation Eric Dumazet
2022-02-03 1:51 ` [PATCH net-next 01/15] net: add netdev->tso_ipv6_max_size attribute Eric Dumazet
2022-02-03 16:34 ` Jakub Kicinski
2022-02-03 16:56 ` Eric Dumazet
2022-02-03 18:58 ` Jakub Kicinski
2022-02-03 19:12 ` Eric Dumazet
2022-02-03 1:51 ` [PATCH net-next 02/15] ipv6: add dev->gso_ipv6_max_size Eric Dumazet
2022-02-03 8:57 ` Paolo Abeni
2022-02-03 15:34 ` Eric Dumazet
2022-02-03 1:51 ` [PATCH net-next 03/15] tcp_cubic: make hystart_ack_delay() aware of BIG TCP Eric Dumazet
2022-02-03 1:51 ` [PATCH net-next 04/15] ipv6: add struct hop_jumbo_hdr definition Eric Dumazet
2022-02-03 1:51 ` [PATCH net-next 05/15] ipv6/gso: remove temporary HBH/jumbo header Eric Dumazet
2022-02-03 18:53 ` Alexander H Duyck
2022-02-03 19:17 ` Eric Dumazet
2022-02-03 19:45 ` Alexander Duyck
2022-02-03 19:59 ` Eric Dumazet
2022-02-03 21:08 ` Alexander H Duyck
2022-02-03 21:41 ` Eric Dumazet
2022-02-04 0:05 ` Alexander Duyck
2022-02-04 0:27 ` Eric Dumazet
2022-02-04 1:14 ` Eric Dumazet
2022-02-04 1:48 ` Eric Dumazet
2022-02-04 2:15 ` Eric Dumazet
2022-02-03 1:51 ` [PATCH net-next 06/15] ipv6/gro: insert " Eric Dumazet
2022-02-03 9:19 ` Paolo Abeni
2022-02-03 15:48 ` Eric Dumazet
2022-02-03 1:51 ` [PATCH net-next 07/15] ipv6: add GRO_IPV6_MAX_SIZE Eric Dumazet
2022-02-03 2:18 ` Eric Dumazet
2022-02-03 10:44 ` Paolo Abeni
2022-02-03 1:51 ` [PATCH net-next 08/15] ipv6: Add hop-by-hop header to jumbograms in ip6_output Eric Dumazet
2022-02-03 9:07 ` Paolo Abeni [this message]
2022-02-03 16:31 ` Eric Dumazet
2022-02-03 1:51 ` [PATCH net-next 09/15] net: increase MAX_SKB_FRAGS Eric Dumazet
2022-02-03 5:02 ` kernel test robot
2022-02-03 5:20 ` Eric Dumazet
2022-02-03 5:31 ` Jakub Kicinski
2022-02-03 6:35 ` Eric Dumazet
2022-02-03 5:23 ` kernel test robot
2022-02-03 5:43 ` kernel test robot
2022-02-03 16:01 ` Paolo Abeni
2022-02-03 17:26 ` Alexander H Duyck
2022-02-03 17:34 ` Eric Dumazet
2022-02-03 17:56 ` Alexander Duyck
2022-02-03 19:18 ` Jakub Kicinski
2022-02-03 19:20 ` Eric Dumazet
2022-02-03 19:54 ` Eric Dumazet
2022-02-04 10:18 ` David Laight
2022-02-04 15:46 ` Alexander Duyck
2022-02-03 1:51 ` [PATCH net-next 10/15] net: loopback: enable BIG TCP packets Eric Dumazet
2022-02-03 1:51 ` [PATCH net-next 11/15] bonding: update dev->tso_ipv6_max_size Eric Dumazet
2022-02-03 1:51 ` [PATCH net-next 12/15] macvlan: enable BIG TCP Packets Eric Dumazet
2022-02-03 1:51 ` [PATCH net-next 13/15] ipvlan: " Eric Dumazet
2022-02-03 1:51 ` [PATCH net-next 14/15] mlx4: support BIG TCP packets Eric Dumazet
2022-02-03 13:04 ` Tariq Toukan
2022-02-03 15:54 ` Eric Dumazet
2022-02-03 1:51 ` [PATCH net-next 15/15] mlx5: " Eric Dumazet
2022-02-03 7:27 ` Tariq Toukan
2022-02-04 4:03 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cefef8b5dfd8f5944e74f5f6bf09692f4984db6a.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=lixiaoyan@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).