From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 010E4C433EF for ; Sun, 12 Jun 2022 09:08:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235596AbiFLJIy (ORCPT ); Sun, 12 Jun 2022 05:08:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229563AbiFLJIx (ORCPT ); Sun, 12 Jun 2022 05:08:53 -0400 Received: from mailout2.hostsharing.net (mailout2.hostsharing.net [IPv6:2a01:37:3000::53df:4ee9:0]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9559129340; Sun, 12 Jun 2022 02:08:51 -0700 (PDT) Received: from h08.hostsharing.net (h08.hostsharing.net [83.223.95.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.hostsharing.net", Issuer "RapidSSL TLS DV RSA Mixed SHA256 2020 CA-1" (verified OK)) by mailout2.hostsharing.net (Postfix) with ESMTPS id 5A0FB1036E627; Sun, 12 Jun 2022 11:08:49 +0200 (CEST) Received: from localhost (unknown [89.246.108.87]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by h08.hostsharing.net (Postfix) with ESMTPSA id 34C8161A0C1B; Sun, 12 Jun 2022 11:08:49 +0200 (CEST) X-Mailbox-Line: From ecd2ab4160b700b99820ae91c35c30ffda3864e7 Mon Sep 17 00:00:00 2001 Message-Id: From: Lukas Wunner Date: Sun, 12 Jun 2022 11:07:46 +0200 Subject: [PATCH net-next v2 0/1] linkwatch use-after-free fix To: Oliver Neukum , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Jann Horn , Oleksij Rempel , Oleksij Rempel , Eric Dumazet Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org, Andrew Lunn , Jacky Chou , Willy Tarreau , Lino Sanfilippo , Philipp Rosenberger , Heiner Kallweit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Discussion on v1 of this patch fizzled out in April without it being applied: https://lore.kernel.org/netdev/18b3541e5372bc9b9fc733d422f4e698c089077c.1650177997.git.lukas@wunner.de/#r This is a vulnerability, we can't just ignore it. Paolo Abeni asked me to explore whether the issue can be fixed in USB Ethernet drivers instead of core networking code. I've done that and presented a patch, but consider it an inferior approach. I'm explaining why in the updated commit message of this patch and I'm rebasing it on net-next. Otherwise it's the same as v1, I still believe that this is the best solution to the problem. Thanks! Lukas Wunner (1): net: linkwatch: ignore events for unregistered netdevs net/core/dev.c | 17 ----------------- net/core/dev.h | 1 - net/core/link_watch.c | 10 ++-------- 3 files changed, 2 insertions(+), 26 deletions(-) -- 2.35.2