From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8514C433EF for ; Wed, 18 May 2022 18:10:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231139AbiERSKr (ORCPT ); Wed, 18 May 2022 14:10:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231801AbiERSKq (ORCPT ); Wed, 18 May 2022 14:10:46 -0400 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81509F43 for ; Wed, 18 May 2022 11:10:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652897444; x=1684433444; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=8YfA4rgQsuU6hIQVlldniJoCFetnxV+mo0jXapiTlNw=; b=KYM8jdrha1jaeVb8OPaZr1advGpXqBrwFuRhvDf3hGwiZJFs6+xSELzz kndbpfayj63CIa7fu9wCaIsf0KoV5KUB+7KRLRHT9u7TJjxh65G6zBR3L 7ci8UeE5HM490pe5FYrovLgCPUlMQX8M2Kr9B573YM8tEi7H9/Hho8Hz/ ZxfziqgvKjB7pPM7QcKqGf2sPdeFArBZk+jbzZ965rK4zDDQxC0Syxo2G DoQVKYB37Z0+8FIsV+DDqK4LMhY1ZwU9QZrOaLha7FaIsvRkaA5c5Kz5n Hd8obIsCihHDm6hIz3MkRpV3wWW5p23CidzOqaoPzSzmtFC5Fz8w1y6Ur g==; X-IronPort-AV: E=McAfee;i="6400,9594,10351"; a="271515325" X-IronPort-AV: E=Sophos;i="5.91,235,1647327600"; d="scan'208";a="271515325" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2022 11:09:50 -0700 X-IronPort-AV: E=Sophos;i="5.91,235,1647327600"; d="scan'208";a="597952373" Received: from rottmaie-mobl1.ger.corp.intel.com ([10.252.53.238]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2022 11:09:45 -0700 Date: Wed, 18 May 2022 21:09:37 +0300 (EEST) From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= To: Ziyang Xuan cc: chandrashekar.devegowda@intel.com, linuxwwan@intel.com, chiranjeevi.rapolu@linux.intel.com, haijun.liu@mediatek.com, m.chetan.kumar@linux.intel.com, ricardo.martinez@linux.intel.com, loic.poulain@linaro.org, ryazanov.s.a@gmail.com, johannes@sipsolutions.net, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, Netdev Subject: Re: [PATCH net-next v2] net: wwan: t7xx: fix GFP_KERNEL usage in spin_lock context In-Reply-To: <20220517064821.3966990-1-william.xuanziyang@huawei.com> Message-ID: References: <20220517064821.3966990-1-william.xuanziyang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 17 May 2022, Ziyang Xuan wrote: > t7xx_cldma_clear_rxq() call t7xx_cldma_alloc_and_map_skb() in spin_lock > context, But __dev_alloc_skb() in t7xx_cldma_alloc_and_map_skb() uses > GFP_KERNEL, that will introduce scheduling factor in spin_lock context. > > Because t7xx_cldma_clear_rxq() is called after stopping CLDMA, so we can > remove the spin_lock from t7xx_cldma_clear_rxq(). > Perhaps Suggested-by: ... would have been appropriate too. > Fixes: 39d439047f1d ("net: wwan: t7xx: Add control DMA interface") > Signed-off-by: Ziyang Xuan -- i.