From: Eric Dumazet <eric.dumazet@gmail.com>
To: William Dauchy <wdauchy@gmail.com>
Cc: NETDEV <netdev@vger.kernel.org>, "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] tcp: add tsval and tsecr to TCP_INFO
Date: Wed, 2 Oct 2019 16:14:37 -0700 [thread overview]
Message-ID: <d0b1f5b1-8182-a1d0-4abf-924a0f050393@gmail.com> (raw)
In-Reply-To: <CAJ75kXZT1Mt_=dqG+YEZHpzDLUZaPK=Nep=S85t9V+cT1TNMfA@mail.gmail.com>
On 10/2/19 3:54 PM, William Dauchy wrote:
> Hello Eric,
>
> On Thu, Oct 3, 2019 at 12:33 AM Eric Dumazet <eric.dumazet@gmail.com> wrote:
>> On 10/2/19 3:10 PM, William Dauchy wrote:
>> Reporting the last recorded values is really not good,
>> a packet capture will give you all this information in a non
>> racy way.
>
> Thank you for your quick answer.
> In my use case I use it on a http server where I tag my requests with
> such informations coming from tcp, which later helps to diagnose some
> issues and create some useful metrics to give me a general signal.
> Does it still sound like an invalid use case?
I would rather use a new getsockopt() to fetch this specific data,
instead of making TCP_INFO bigger for everyone :/
ss command can dump millions of sockets in busy hosts, we need to be
careful of TCP_INFO size.
next prev parent reply other threads:[~2019-10-02 23:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 22:10 [PATCH] tcp: add tsval and tsecr to TCP_INFO William Dauchy
2019-10-02 22:33 ` Eric Dumazet
2019-10-02 22:54 ` William Dauchy
2019-10-02 23:14 ` Eric Dumazet [this message]
2019-10-03 5:47 ` William Dauchy
2019-10-26 18:45 ` [PATCH v2] tcp: add timestamp options fetcher William Dauchy
2019-10-26 20:42 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0b1f5b1-8182-a1d0-4abf-924a0f050393@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=wdauchy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).