From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Vlad Buslov <vlad@buslov.dev>, Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
xiyou.wangcong@gmail.com, jiri@resnulli.us
Subject: Re: [PATCH net-next] net: sched: alias action flags with TCA_ACT_ prefix
Date: Tue, 24 Nov 2020 08:39:47 -0500 [thread overview]
Message-ID: <d1167677-c813-35d2-144a-2246dcf8fd59@mojatatu.com> (raw)
In-Reply-To: <87v9dv9k8q.fsf@buslov.dev>
On 2020-11-24 4:28 a.m., Vlad Buslov wrote:
> On Mon 23 Nov 2020 at 23:22, Jakub Kicinski <kuba@kernel.org> wrote:
>> On Sat, 21 Nov 2020 18:09:02 +0200 Vlad Buslov wrote:
>>> Currently both filter and action flags use same "TCA_" prefix which makes
>>> them hard to distinguish to code and confusing for users. Create aliases
>>> for existing action flags constants with "TCA_ACT_" prefix.
>>>
>>> Signed-off-by: Vlad Buslov <vlad@buslov.dev>
>>
>> Are we expecting to add both aliases for all new flags?
>
> I don't think it makes sense to have both aliases for any new flags.
>
Agreed.
cheers,
jamal
next prev parent reply other threads:[~2020-11-24 13:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-21 16:09 [PATCH net-next] net: sched: alias action flags with TCA_ACT_ prefix Vlad Buslov
2020-11-23 0:11 ` Jamal Hadi Salim
2020-11-23 21:22 ` Jakub Kicinski
2020-11-24 9:28 ` Vlad Buslov
2020-11-24 13:39 ` Jamal Hadi Salim [this message]
2020-11-24 16:24 ` Jakub Kicinski
2020-11-24 16:39 ` Vlad Buslov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1167677-c813-35d2-144a-2246dcf8fd59@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vlad@buslov.dev \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).