From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3C7DC433FE for ; Tue, 14 Dec 2021 06:40:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230511AbhLNGkQ (ORCPT ); Tue, 14 Dec 2021 01:40:16 -0500 Received: from mout.gmx.net ([212.227.17.22]:56195 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230494AbhLNGkP (ORCPT ); Tue, 14 Dec 2021 01:40:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1639463994; bh=AnY0FXth2uT3DootG1OkAz5YN7wfCnOeoOzAnGdj19g=; h=X-UI-Sender-Class:Subject:From:To:Cc:Date:In-Reply-To:References; b=B3b8jHviVMGMjfE/xf4LSW3S8HdmyW1U1WtQOf57rTf0Z4oKgepiogq2Xiu1DgHj0 fggO/+LFyyzHkRbPrHjxHXJqnxvFeombw5ATmRYNsWxwWqGeFM/14u0YaKVBJlAcVp uVYCxbJCcdbfnvTOJMuY8hOJxu5akUASuK6suIv4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from machineone.fritz.box ([84.190.129.90]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MA7KU-1mmX4t3wQE-00BfUn; Tue, 14 Dec 2021 07:39:54 +0100 Message-ID: Subject: Re: [PATCH] igc: Avoid possible deadlock during suspend/resume From: Stefan Dietrich To: Vinicius Costa Gomes , Thorsten Leemhuis Cc: kuba@kernel.org, greg@kroah.com, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, regressions@lists.linux.dev Date: Tue, 14 Dec 2021 07:39:52 +0100 In-Reply-To: <87wnk8qrt8.fsf@intel.com> References: <87r1awtdx3.fsf@intel.com> <20211201185731.236130-1-vinicius.gomes@intel.com> <5a4b31d43d9bf32e518188f3ef84c433df3a18b1.camel@gmx.de> <87o85yljpu.fsf@intel.com> <063995d8-acf3-9f33-5667-f284233c94b4@leemhuis.info> <8e59b7d6b5d4674d5843bb45dde89e9881d0c741.camel@gmx.de> <5c5b606a-4694-be1b-0d4b-80aad1999bd9@leemhuis.info> <87h7bgrn0j.fsf@intel.com> <6bcce8e66fde064fd2879e802970bb4a8f382743.camel@gmx.de> <87wnk8qrt8.fsf@intel.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:RiWRIMtuWVXoDkIC7M8NSnDGO7Rp+EHeW6tydokhA9qJQYBrtT8 G5ke373qJUrZ+XMLoOyTO1Omua7GunCbdokEm4xPCBsBSY08/wex9vx82NfNiVzDgy0Eblj b0EGdtraERvm8DlBDbhPVJoIOF/HNpu1TIFIAT3gMh96njRlUTUQ+jvy+q0GF9RxKE9KSUL WSvCy+YczVY6SfzCR7ZEg== X-UI-Out-Filterresults: notjunk:1;V03:K0:RI6SScsUaKY=:T3p6lPS1jMOTGse6jxNDI7 yHkJ5dhYkJ71EI3Hj2V3YG6aaNVYRB3m0fOt+l+bOfO3vrqyrFRv4SfpasneEKilKMXdIOaSr xWuRhX6yyFQcJpnQDBCYrjrllUF+rwvb1WNYQw6R3lLPzFmqUnHmgZjUxGTDdFFReZnz193dv OsMwkvjNsyfRmcdfromy4ChOugP+RatLUIEtEx9VsZ5cgf6dD0YDMxy2E7GF6YdFsfVPKmqcL jEwoC33sijQZDX74qSR7eQQxpHA7GjmhsSF0eKVW6bUkb0T5OtLVpQbbeTAeckzX9ag3FqM23 OiB6H4jeenILWbTpnJP7k1irX8OgRNxaEk42eK+4lZXBjM1ummgFNRQABwCItkAXicl8eVEOB QmqMUS5XCv2B+Rd6sH+3C5f+nDqdTU3ShwVtZwgj3ZBbSybYsT1AmeM2MDqXUSGYtyvvu+i78 IbURMG85tFy+PBn94diG8qx2UARXc7TA+z1zffnp3ZedN8/ZXR9FFX48almAEgIVOvfmLl4// eETv5yDLu1/RWqbZ9ZNynrTOc178arr9p8EmMPo2Qbl36QjVR0SmPu+8IVjm/8LLwIm2/y2Xu LQykYIQhX3w5KPNBVrtXrQyD4xUfXWpucHtQcFHDRFFQGB+BjigNdE0eKwgAyNqUb4wVdMQyz 8Hmf7r9whTxxI88l/y/REIDIUrIzH2+rJOc/xHuO0w5T11RAQN2JDXnmzE2VuPlr8lrC8LcSP MS+JlqoSX002QytTrTq3K4mMlqzZPD5qes82wseJ/yZ7Qb/vWh4+nbwar3t7Vnd8D1yl5J84q 0ZMUyiEmuJNJNp7ZX5Akll9td+17Tq2e1odcGHVzLxz457RPhDjk11SehVCYIu0dtfe4pJ5zV Yitshd8LHRH2hnpWO8E9ZjbfHIz/o3QQzyZzSeZNwgmVDhOR2RNMGamosAq1BLOUt6fOY7WFt JBZfBntVst0wDhQqVV83K2Go/KBt1MpXRXMLSHM8oiQ85D47PSII9XfC9s9tZiYt3doGqxt9I zKENY9IIqNxwf84r5gU2hnU4z8qgGdHy6ZmryIca/e0IIHZ+dYHa9nJXfT9Y72YNeQ== Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Vinicius, thanks for the info and you work on that issue. Stefan On Mon, 2021-12-13 at 10:32 -0800, Vinicius Costa Gomes wrote: > Hi Stefan, > > Stefan Dietrich writes: > > > Hi Vinicius, > > > > thanks a lot - that patch fixed it! Both "normal" shutdown as well > > as > > ifdown/ifup are working without issues now if CONFIG_PCIE_PTM is > > enabled in the kernel config. > > Great! > > This patch is mostly to give us time to investigate, this seems to be > an > issue related to that specific i225 model. I have to track one down > and > perhaps talk to the hardware folks and see what I am doing wrong. > > > I've done a DSL download/upload speed comparison against my current > > 5.14.0-19.2 and did not see any performance differences outside > > margin > > of error. I currently have no other Linux machine I could use for > > iperf > > but I will report if I encounter any issues. > > > > I wasn't expecting any changes in performance, I was more asking if > you > had some use case for PCIe PTM, and something stopped working. It > seems > that the answer is no. That's good. > > > As I am not familiar with the kernel development procedure: can you > > give a rough estimate when we may expect this patch in the stable > > branch? > > I will write a useful commit message, take another closer look to see > if > I am still missing something and propose the patch upstream. From > there > until it's accepted in a stable tree, I guess it could take a few > days, > a week, perhaps. > > > > > Thanks again, > > Stefan > > > > > > > > On Fri, 2021-12-10 at 16:41 -0800, Vinicius Costa Gomes wrote: > > > Hi Stefan, > > > > > > Stefan Dietrich writes: > > > > > > > Agreed and thanks for the pointers; please see the log files > > > > and > > > > .config attached as requested. > > > > > > > > > > Thanks for the logs. > > > > > > Very interesting that the initialization of the device is fine, > > > so > > > it's > > > something that happens later. > > > > > > Can you test the attached patch? > > > > > > If the patch works, I would also be interested if you notice any > > > loss > > > of > > > functionality with your NIC. (I wouldn't think so, as far as I > > > know, > > > i225-V models have PTM support but don't have any PTP support). > > > > > > > Cheers, > > > > Stefan > > > > > > > > > > > > On Fri, 2021-12-10 at 15:01 +0100, Thorsten Leemhuis wrote: > > > > > On 10.12.21 14:45, Stefan Dietrich wrote: > > > > > > thanks for keeping an eye on the issue. I've sent the files > > > > > > in > > > > > > private > > > > > > because I did not want to spam the mailing lists with them. > > > > > > Please > > > > > > let > > > > > > me know if this is the correct procedure. > > > > > > Cheers, > > Cheers,