From: Larry Finger <Larry.Finger@lwfinger.net>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Chaoming Li <chaoming_li@realsil.com.cn>,
Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtlwifi: rtl8723be: fix duplicated code for different branches
Date: Wed, 30 Aug 2017 23:42:18 -0500 [thread overview]
Message-ID: <d26873ed-3c1e-f47c-0aab-e8e670c8ced5@lwfinger.net> (raw)
In-Reply-To: <20170830170424.GA19424@embeddedgus>
On 08/30/2017 12:04 PM, Gustavo A. R. Silva wrote:
> Refactor code in order to avoid identical code for different branches.
>
> Addresses-Coverity-ID: 1248728
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
According to Realtek, this change is OK.
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks,
Larry
> ---
> This issue was reported by Coverity and it was tested by compilation only.
> Please, verify if this is not a copy/paste error.
> Also, notice this code has been there since 2014.
>
> drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c
> index 131c0d1..15c117e 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c
> @@ -883,12 +883,8 @@ static void rtl8723be_dm_txpower_tracking_callback_thermalmeter(
> if ((rtldm->power_index_offset[RF90_PATH_A] != 0) &&
> (rtldm->txpower_track_control)) {
> rtldm->done_txpower = true;
> - if (thermalvalue > rtlefuse->eeprom_thermalmeter)
> - rtl8723be_dm_tx_power_track_set_power(hw, BBSWING, 0,
> - index_for_channel);
> - else
> - rtl8723be_dm_tx_power_track_set_power(hw, BBSWING, 0,
> - index_for_channel);
> + rtl8723be_dm_tx_power_track_set_power(hw, BBSWING, 0,
> + index_for_channel);
>
> rtldm->swing_idx_cck_base = rtldm->swing_idx_cck;
> rtldm->swing_idx_ofdm_base[RF90_PATH_A] =
>
next prev parent reply other threads:[~2017-08-31 4:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 17:04 [PATCH] rtlwifi: rtl8723be: fix duplicated code for different branches Gustavo A. R. Silva
2017-08-31 4:42 ` Larry Finger [this message]
2017-08-31 13:00 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d26873ed-3c1e-f47c-0aab-e8e670c8ced5@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=gustavo@embeddedor.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).